eden-emu/eden
24
3
Fork 18
Code Issues 87 Pull requests 76 Projects 1 Releases 7 Wiki Activity Actions

[android] input over(lay)haul 1: Auto-hide input overlay setting #493

Merged
crueter merged 6 commits from kleidis/eden:overlay-overhaul into master 2025-09-29 22:40:04 +02:00
Conversation 5 Commits 6 Files changed 14 +409 -6
kleidis commented 2025-09-15 14:15:26 +02:00
Member
Copy link

This is step 1 of #47 which was the easiest to implement. How was this not implemented on yuzu already?
Would prefer if more people tested this than the usual amount.

This is step 1 of https://git.eden-emu.dev/eden-emu/eden/issues/47 which was the easiest to implement. How was this not implemented on yuzu already? Would prefer if more people tested this than the usual amount.
crueter approved these changes 2025-09-24 19:29:07 +02:00
Dismissed
MaranBr approved these changes 2025-09-24 19:30:15 +02:00
Dismissed
crueter requested changes 2025-09-27 01:20:52 +02:00
crueter left a comment
Owner
Copy link

We will probably eventually want to add an auto-hide when controller is connected mayhaps

We will probably eventually want to add an auto-hide when controller is connected mayhaps
src/android/app/src/main/jni/android_settings.h Outdated
@ -80,2 +80,4 @@
Settings::Specialization::Paired, true,
true};
Settings::Setting<u32> perf_overlay_border{linkage, 0, "input_overlay_auto_hide",
crueter commented 2025-09-27 01:20:21 +02:00
Owner
Copy link

change varname here

change varname here
kleidis marked this conversation as resolved
src/android/app/src/main/res/values/arrays.xml Outdated
@ -500,0 +511,4 @@
<item>@string/overlay_auto_hide_45s</item>
<item>@string/overlay_auto_hide_50s</item>
<item>@string/overlay_auto_hide_55s</item>
<item>@string/overlay_auto_hide_60s</item>
crueter commented 2025-09-27 01:19:29 +02:00
Owner
Copy link

this should probably just be a spinbox

this should probably just be a spinbox
kleidis commented 2025-09-27 17:44:26 +02:00
Author
Member
Copy link

Do we have input settings type for INT settings like that on Android? I am ware of only StringInputSetting
This might require a custom Kotlin settings type, but I could be wrong

Do we have input settings type for INT settings like that on Android? I am ware of only StringInputSetting This might require a custom Kotlin settings type, but I could be wrong
crueter commented 2025-09-27 17:45:30 +02:00
Owner
Copy link

iirc we only have the SliderSetting. Probably wouldn't hurt to make a SpinBoxSetting.

iirc we only have the SliderSetting. Probably wouldn't hurt to make a SpinBoxSetting.
kleidis commented 2025-09-27 17:49:43 +02:00
Author
Member
Copy link

Hmm, ill check it out. Could be useful later on.

Hmm, ill check it out. Could be useful later on.
kleidis marked this conversation as resolved
kleidis commented 2025-09-27 17:48:34 +02:00
Author
Member
Copy link

We will probably eventually want to add an auto-hide when controller is connected mayhaps

Yes, but ill need to research how to do that, it will probably be the final part of the overhaul after grid snapping and porting stuff from Azahar

> We will probably eventually want to add an auto-hide when controller is connected mayhaps Yes, but ill need to research how to do that, it will probably be the final part of the overhaul after grid snapping and porting stuff from Azahar
👍 1
kleidis force-pushed overlay-overhaul from af7f98f5be
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
to 5b37b9e9b9
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
2025-09-27 19:29:40 +02:00 Compare
kleidis dismissed crueter's review 2025-09-27 19:29:40 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

kleidis dismissed MaranBr's review 2025-09-27 19:29:40 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

MaranBr force-pushed overlay-overhaul from 4c300d7809
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
to d838e96d90
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
2025-09-28 16:34:17 +02:00 Compare
crueter merged commit 03c7d6ce4a into master 2025-09-29 22:40:04 +02:00
crueter deleted branch overlay-overhaul 2025-09-29 22:40:04 +02:00
Producdevity commented 2025-12-01 13:15:44 +01:00
Member
Copy link

I am working on this "We will probably eventually want to add an auto-hide when controller is connected mayhaps" @crueter

I am working on this "We will probably eventually want to add an auto-hide when controller is connected mayhaps" @crueter
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!493
No description provided.