[ci, tools] shellcheck-ed #397

Closed
DraVee wants to merge 8 commits from DraVee:old/shellcheck into master

8 commits

Author SHA1 Message Date
e8d03a13e7 [license] keep hacky way under UPDATE
All checks were successful
eden-license / license-header (pull_request) Successful in 42s
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
2025-09-18 02:29:28 +02:00
3ffaa7c19c [license] reduce usage of while and improve template usage
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
2025-09-18 02:29:28 +02:00
ca7001639b [license] include .ps1, improve commit message and shebang first
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
2025-09-18 02:29:28 +02:00
13ab0d3fcb [license] Fix license headers [script] 2025-09-18 02:29:28 +02:00
80a8d71551 license-header.sh: This is complete refactor
* It now fix in-place header with the same owner, see next commit

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
2025-09-18 02:29:28 +02:00
3c1174cc64 [ci] Make it POSIX-compliant
* tested on Ubuntu 25.04

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
2025-09-18 02:29:28 +02:00
eb1140568e use better license-header impl that is not as cursed
Signed-off-by: crueter <crueter@eden-emu.dev>
2025-09-18 02:29:28 +02:00
1d43b20312 [ci, tools] shellcheck-ed
* now license-header.sh is POSIX compliant
* update-icons now checks for dependencies the correct way
* add --help to license-header
* nuke reset-submodules
* add missing shebang to .ci/windows/package.sh

* Below the error/warnings/infos from shellcheck:
-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.

-- SC3054 (warning): In POSIX sh, array references are undefined.
-- SC2155 (warning): Declare and assign separately to avoid masking return values.
-- SC2046 (warning): Quote this to prevent word splitting.

-- SC2236 (style): Use -n instead of ! -z.
-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
-- SC2001 (style): See if you can use ${variable//search/replace} instead.

-- SC2086 (info): Double quote to prevent globbing and word splitting.
-- SC2185 (info): Some finds don't have a default path. Specify '.' explicitly.

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
2025-09-18 02:29:28 +02:00