eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[fs] Fix integrity check validation for new updates #395

Merged
crueter merged 16 commits from improve-integrity-check into master 2025-09-12 16:02:13 +02:00
Conversation 4 Commits 16 Files changed 3 +17 -40
MaranBr commented 2025-09-08 20:07:46 +02:00
Member
Copy link

This fixes the integrity check validation for new updates.

This fixes the integrity check validation for new updates.
MaranBr added 1 commit 2025-09-08 20:07:47 +02:00
Improve integrity check validation code
Some checks failed
eden-license / license-header (pull_request) Failing after 39s
Details
a03abd15e9
MaranBr added 1 commit 2025-09-08 20:15:43 +02:00
Organize some things
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
9480c0d22d
MaranBr added 1 commit 2025-09-08 20:32:30 +02:00
Fix build
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
8826a619f8
MaranBr added 1 commit 2025-09-08 21:53:49 +02:00
Restore old behavior
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
bc060aa1f8
crueter approved these changes 2025-09-08 22:13:58 +02:00
Dismissed
MaranBr added 1 commit 2025-09-09 16:48:23 +02:00
Avoid crashes when installing new updates
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
856b1ab5b8
MaranBr dismissed crueter's review 2025-09-09 16:48:23 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

MaranBr changed title from [fs] Improve integrity check validation code to WIP: [fs] Improve integrity check validation code 2025-09-09 16:49:44 +02:00
MaranBr added 1 commit 2025-09-09 17:16:57 +02:00
Fix build
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
64066e2eb9
MaranBr added 1 commit 2025-09-09 20:22:07 +02:00
Adjust some things
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
0522fe79ff
MaranBr changed title from WIP: [fs] Improve integrity check validation code to [fs] Improve integrity check validation code 2025-09-09 20:22:16 +02:00
crueter force-pushed improve-integrity-check from 0522fe79ff to 4561991933 2025-09-09 20:48:28 +02:00 Compare
MaranBr added 9 commits 2025-09-09 21:03:08 +02:00
Improve integrity check validation code
Some checks failed
eden-license / license-header (pull_request) Failing after 39s
Details
a03abd15e9
Organize some things
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
9480c0d22d
Fix build
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
8826a619f8
Restore old behavior
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
bc060aa1f8
Avoid crashes when installing new updates
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
856b1ab5b8
Fix build
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
64066e2eb9
Adjust some things
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
0522fe79ff
Ready to merge
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
0b69742b3b
MaranBr changed title from [fs] Improve integrity check validation code to [fs] Fix integrity check validation for new updates 2025-09-09 21:09:59 +02:00
crueter approved these changes 2025-09-10 02:24:11 +02:00
Dismissed
src/core/file_sys/fssystem/fssystem_nca_file_system_driver.cpp
@ -1051,8 +1051,8 @@ Result NcaFileSystemDriver::CreatePatchMetaStorage(
ASSERT(out_aes_ctr_ex_meta != nullptr);
ASSERT(out_indirect_meta != nullptr);
ASSERT(base_storage != nullptr);
ASSERT(patch_info.HasAesCtrExTable());
crueter commented 2025-09-10 02:23:22 +02:00
Owner
Copy link

What's this for?

What's this for?
MaranBr commented 2025-09-10 02:34:26 +02:00
Author
Member
Copy link

These two asserts are not needed at this point in the code.

These two asserts are not needed at this point in the code.
MaranBr marked this conversation as resolved
src/core/file_sys/fssystem/fssystem_nca_file_system_driver.cpp
@ -1336,3 +1336,2 @@
}
storage_info.SetDataStorage(std::make_shared<OffsetVfsFile>(
std::move(base_storage), layer_info.size, last_layer_info_offset));
storage_info[level_hash_info.max_layers - 1] = std::make_shared<OffsetVfsFile>(
crueter commented 2025-09-10 02:24:08 +02:00
Owner
Copy link

Seems interesting, what's in SetDataStorage that caused issues?

Seems interesting, what's in SetDataStorage that caused issues?
MaranBr commented 2025-09-10 02:37:51 +02:00
Author
Member
Copy link

This is something I will look into further when I have more time. It's safe for now.

This is something I will look into further when I have more time. It's safe for now.
MaranBr marked this conversation as resolved
Shinmegumi approved these changes 2025-09-12 15:58:22 +02:00
crueter approved these changes 2025-09-12 16:02:07 +02:00
crueter merged commit 3fbfd64722 into master 2025-09-12 16:02:13 +02:00
crueter deleted branch improve-integrity-check 2025-09-12 16:02:13 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Shinmegumi
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#395
No description provided.
Delete branch "improve-integrity-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?