eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[Legacy VMA] remove memory alignment, it's pointless and wastes RAM #391

Merged
MaranBr merged 1 commit from Calchan/eden:legacy into legacy 2025-09-14 15:23:07 +02:00
Conversation 5 Commits 1 Files changed 1 +5 -15
Calchan commented 2025-09-07 18:16:16 +02:00
Member
Copy link

Final cleanups after new VMA. It already takes care of properly aligning, so we no longer need these.

Final cleanups after new VMA. It already takes care of properly aligning, so we no longer need these.
Calchan added 1 commit 2025-09-07 18:16:17 +02:00
Lizzie commented 2025-09-07 22:49:47 +02:00
Member
Copy link

Removing alignment constraints "partially" fixes SSBU at the moment - due to an OOM with OVER 6 G&W... I remember doing an edit similar to this - but I'm sure Mali and Adreno GPUs would prefer if the buffers were aligned..

Removing alignment constraints "partially" fixes SSBU at the moment - due to an OOM with OVER 6 G&W... I remember doing an edit similar to this - but I'm sure Mali and Adreno GPUs would prefer if the buffers were aligned..
Calchan commented 2025-09-07 23:18:45 +02:00
Author
Member
Copy link

@Lizzie wrote in #391 (comment):

Removing alignment constraints "partially" fixes SSBU at the moment - due to an OOM with OVER 6 G&W... I remember doing an edit similar to this - but I'm sure Mali and Adreno GPUs would prefer if the buffers were aligned..

I have tested this on a SD865 with Qualcomm drivers and I couldn't see any difference between with and without.
Also: https://discord.com/channels/1367654015269339267/1408301387858575380/1414108218627457064

@Lizzie wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/391#issuecomment-3170: > Removing alignment constraints "partially" fixes SSBU at the moment - due to an OOM with OVER 6 G&W... I remember doing an edit similar to this - but I'm sure Mali and Adreno GPUs would prefer if the buffers were aligned.. I have tested this on a SD865 with Qualcomm drivers and I couldn't see any difference between with and without. Also: https://discord.com/channels/1367654015269339267/1408301387858575380/1414108218627457064
MaranBr approved these changes 2025-09-08 00:26:13 +02:00
Calchan commented 2025-09-08 01:05:23 +02:00
Author
Member
Copy link

Also see the comment I'm responding to here: https://discord.com/channels/1367654015269339267/1391062243625537566/1414339643029065850

Also see the comment I'm responding to here: https://discord.com/channels/1367654015269339267/1391062243625537566/1414339643029065850
Shinmegumi approved these changes 2025-09-12 16:10:07 +02:00
MaranBr changed title from Legacy VMA: remove memory alignment, it's pointless and wastes RAM to [Legacy VMA] remove memory alignment, it's pointless and wastes RAM 2025-09-14 15:22:53 +02:00
MaranBr merged commit 3a402d9f89 into legacy 2025-09-14 15:23:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MaranBr
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#391
No description provided.
Delete branch "Calchan/eden:legacy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?