eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

WIP: [endermag] crash point hunt and guard #3824

Draft
xbzk wants to merge 2 commits from xbzk/unreal-unsafe-junk-guards into master
pull from: xbzk/unreal-unsafe-junk-guards
merge into: eden-emu:master
Conversation 0 Commits 2 Files changed 3 +170 -5
xbzk commented 2026-04-03 23:56:34 +02:00
Member
Copy link

Since i am not obtaining success in finding real culprit, decided to guard the crashes one by one for a change.
No real solution, but no problem either.

Current state has 4 guards, in which two are proved recurrent and mutually exclusive:

-KeplerCompute::ProcessLaunch (highly recurrent)
-DrawManager::ProcessDraw for indexed buffers (very frquent too)

Also, for convenience:
-DrawManager::ProcessDraw for vertex buffers
-DrawManager::ProcessDrawIndirect
(these never occured)

Additionally, antiflicker from PR 3574 is on for Ender Magnolia extended tests.

Since i am not obtaining success in finding real culprit, decided to guard the crashes one by one for a change. No real solution, but no problem either. Current state has 4 guards, in which two are proved recurrent and mutually exclusive: -KeplerCompute::ProcessLaunch (highly recurrent) -DrawManager::ProcessDraw for indexed buffers (very frquent too) Also, for convenience: -DrawManager::ProcessDraw for vertex buffers -DrawManager::ProcessDrawIndirect (these never occured) Additionally, antiflicker from PR 3574 is on for Ender Magnolia extended tests.
[endermag] antiflicker + 4 crash guards
Some checks reported errors
eden-license / license-header (pull_request) Failing after 23s
Details
GitHub Actions [CI] Build cancelled
Details
f484c653a5
xbzk force-pushed xbzk/unreal-unsafe-junk-guards from f484c653a5
Some checks reported errors
eden-license / license-header (pull_request) Failing after 23s
Details
GitHub Actions [CI] Build cancelled
Details
to 208c27a98e
Some checks failed
eden-license / license-header (pull_request) Successful in 23s
Details
GitHub Actions [CI] Build failed
Details
2026-04-03 23:58:28 +02:00 Compare
xbzk changed title from WIP: [endermag] antiflicker + 4 crash guards to WIP: [endermag] crash point hunt and guard 2026-04-03 23:59:14 +02:00
touch ci
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
605d2f02b4 
Signed-off-by: xbzk <xbzk@eden-emu.dev>
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin xbzk/unreal-unsafe-junk-guards:xbzk/unreal-unsafe-junk-guards
git switch xbzk/unreal-unsafe-junk-guards
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3824
No description provided.