eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[shader_recompiler] Fix IsScaled dynamic indexing reading wrong bit source #3789

Open
MaranBr wants to merge 3 commits from shader_recompiler into master
pull from: shader_recompiler
merge into: eden-emu:master
Conversation 1 Commits 3 Files changed 1 +6 -1
MaranBr commented 2026-03-27 21:07:52 +01:00
Member
Copy link

The non-immediate path in IsScaled was incorrectly using index_value as the source for OpBitFieldUExtract, instead of loading the corresponding word from the push constant bitmask.

The non-immediate path in IsScaled was incorrectly using index_value as the source for OpBitFieldUExtract, instead of loading the corresponding word from the push constant bitmask.
Fix IsScaled dynamic indexing reading wrong bit source
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
9adc54258a
CamilleLaVey approved these changes 2026-03-29 03:00:24 +02:00
Dismissed
MaranBr force-pushed shader_recompiler from 9adc54258a
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
to 46081954d4
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
GitHub Actions [CI] Build succeeded
Details
2026-03-31 20:12:50 +02:00 Compare
MaranBr force-pushed shader_recompiler from 46081954d4
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
GitHub Actions [CI] Build succeeded
Details
to 04d9b0812a
All checks were successful
eden-license / license-header (pull_request) Successful in 46s
Details
GitHub Actions [CI] Build succeeded
Details
2026-04-01 02:12:08 +02:00 Compare
Use shift operations for dynamic bit extraction for better performance
Some checks failed
eden-license / license-header (pull_request) Has been cancelled
Details
81d556fe9b
MaranBr dismissed CamilleLaVey's review 2026-04-02 14:54:00 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

MaranBr force-pushed shader_recompiler from 81d556fe9b
Some checks failed
eden-license / license-header (pull_request) Has been cancelled
Details
to e6cd1033e9
Some checks reported errors
eden-license / license-header (pull_request) Successful in 42s
Details
GitHub Actions [CI] Build cancelled
Details
2026-04-02 14:54:15 +02:00 Compare
Ops
All checks were successful
eden-license / license-header (pull_request) Successful in 38s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
90f4acd549
MaranBr force-pushed shader_recompiler from 90f4acd549
All checks were successful
eden-license / license-header (pull_request) Successful in 38s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
to b834c23477
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
2026-04-03 17:38:47 +02:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin shader_recompiler:shader_recompiler
git switch shader_recompiler
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
crueter
MrPurple666
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3789
No description provided.