eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[settings] modify reported product_model #3783

Open
Lizzie wants to merge 4 commits from lizzie/product-model-wawa into master
pull from: lizzie/product-model-wawa
merge into: eden-emu:master
Conversation 2 Commits 4 Files changed 7 +20 -3
Lizzie commented 2026-03-26 05:42:35 +01:00
Member
Copy link

I'll watch in utter disappointment.

Signed-off-by: lizzie lizzie@eden-emu.dev

I'll watch in utter disappointment. Signed-off-by: lizzie <lizzie@eden-emu.dev>
[settings] modify reported product_model
Some checks reported errors
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build cancelled
Details
500ba240d8 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
crueter requested changes 2026-03-26 05:43:14 +01:00
crueter left a comment
Owner
Copy link

Don't forget Android.

Don't forget Android.
default=1
Some checks reported errors
eden-license / license-header (pull_request) Successful in 36s
Details
GitHub Actions [CI] Build cancelled
Details
e9e036d935
crueter reviewed 2026-03-26 05:44:02 +01:00
src/core/hle/service/set/system_settings_server.cpp Outdated
@ -1160,3 +1160,3 @@
// Most certainly should be 1 -- definitely should not be 2, but it's worth tinkering with anyways
u32 const product_model = 1;
auto const product_model = ::Settings::values.product_model.GetValue();
LOG_WARNING(Service_SET, "(STUBBED) called, product_model={}", product_model);
crueter commented 2026-03-26 05:44:02 +01:00
Owner
Copy link

Not sure this should be considered stubbed anymore, eh?

Not sure this should be considered stubbed anymore, eh?
Lizzie marked this conversation as resolved
androiiii
Some checks failed
eden-license / license-header (pull_request) Successful in 35s
Details
GitHub Actions [CI] Build failed
Details
554c0d377b
forgot comma... haha
Some checks failed
eden-license / license-header (pull_request) Successful in 33s
Details
GitHub Actions [CI] Build failed
Details
df6e3acd52
Lizzie force-pushed lizzie/product-model-wawa from df6e3acd52
Some checks failed
eden-license / license-header (pull_request) Successful in 33s
Details
GitHub Actions [CI] Build failed
Details
to fe5fd4d0ce
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
2026-03-27 01:17:41 +01:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin lizzie/product-model-wawa:lizzie/product-model-wawa
git switch lizzie/product-model-wawa
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
MaranBr
CamilleLaVey
Maufeat
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3783
No description provided.