eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[cmake] Fix macOS frameworks, and icon set usage #3782

Merged
crueter merged 2 commits from ios-icon into master 2026-03-26 07:59:54 +01:00
Conversation 2 Commits 2 Files changed 7 +313 -13
crueter commented 2026-03-26 04:05:57 +01:00
Owner
Copy link
  • The Xcode generator /mandates/ that you pass in the .icon directory
    into the build system, where it can then compose the asset itself.
  • Assets.car and eden.icns were improperly handled; they are now
    automatically generated and should properly be applied as needed. I
    will need someone on Tahoe to confirm, however, as I am on Sequoia.
  • Added some missing frameworks, ported from the KosmicKrisp branch.

Signed-off-by: crueter crueter@eden-emu.dev

- The Xcode generator /mandates/ that you pass in the `.icon` directory into the build system, where it can then compose the asset itself. - Assets.car and eden.icns were improperly handled; they are now automatically generated and should properly be applied as needed. I will need someone on Tahoe to confirm, however, as I am on Sequoia. - Added some missing frameworks, ported from the KosmicKrisp branch. Signed-off-by: crueter <crueter@eden-emu.dev>
[cmake] Fix macOS frameworks, and icon set usage
Some checks failed
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build failed
Details
933feab72e
 
- The Xcode generator /mandates/ that you pass in the `.icon` directory
  into the build system, where it can then compose the asset itself.
- Assets.car and eden.icns were improperly handled; they are now
  automatically generated and should properly be applied as needed. I
  will need someone on Tahoe to confirm, however, as I am on Sequoia.
- Added some missing frameworks, ported from the KosmicKrisp branch.

Signed-off-by: crueter <crueter@eden-emu.dev>
crueter commented 2026-03-26 04:07:43 +01:00
Author
Owner
Copy link

In theory this should help iOS. You pretty much have to use the Xcode generator on iOS, otherwise you're going to have a really bad time.

In theory this *should* help iOS. You pretty much *have* to use the Xcode generator on iOS, otherwise you're going to have a really bad time.
Typo
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
914cf32316
 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter commented 2026-03-26 07:59:50 +01:00
Author
Owner
Copy link

confirmed working on tahoe

confirmed working on tahoe
crueter merged commit 93472023e2 into master 2026-03-26 07:59:54 +01:00
crueter deleted branch ios-icon 2026-03-26 07:59:54 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Lizzie
CamilleLaVey
Maufeat
MrPurple666
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3782
No description provided.