eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[common] use handrolled string utility conversions instead of wstring codecvt #3773

Open
Lizzie wants to merge 2 commits from lizzie/wstring-uni-123 into master
pull from: lizzie/wstring-uni-123
merge into: eden-emu:master
Conversation 0 Commits 2 Files changed 1 +109 -7
Lizzie commented 2026-03-25 00:21:41 +01:00
Member
Copy link

thanks to @chrelliott978 for the initial impl, basically clang will yell at you if you dare use wstring_codecvt<> and some other shit, and to be fair one day it will be removed because it's deprecated (but it's c++, we know it will NEVER be deprecated)

either way this makes clang shut up

untested at all

Signed-off-by: lizzie lizzie@eden-emu.dev

thanks to @chrelliott978 for the initial impl, basically clang will yell at you if you dare use wstring_codecvt<> and some other shit, and to be fair one day it will be removed because it's deprecated (but it's c++, we know it will NEVER be deprecated) either way this makes clang shut up untested at all Signed-off-by: lizzie <lizzie@eden-emu.dev>
[common] use handrolled string utility conversions instead of wstring codecvt
Some checks reported errors
eden-license / license-header (pull_request) Failing after 32s
Details
GitHub Actions [CI] Build cancelled
Details
71e713483f 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
license
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
9f7e9b1864
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin lizzie/wstring-uni-123:lizzie/wstring-uni-123
git switch lizzie/wstring-uni-123
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
crueter
MrPurple666
MaranBr
CamilleLaVey
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3773
No description provided.