eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

Revert "[vk] Simplified layouts per driver configuration (#3271)" #3571

Merged
CamilleLaVey merged 2 commits from lizzie/revert-evil-mali into master 2026-02-19 04:07:46 +01:00
Conversation 6 Commits 2 Files changed 10 +82 -384
Lizzie commented 2026-02-17 20:22:57 +01:00
Member
Copy link

causes evil VUID bullshit

This reverts commit 75fda70db2.

causes evil VUID bullshit This reverts commit 75fda70db293123817b8852632fd47a6984741a4.
Revert "[vk] Simplified layouts per driver configuration (#3271)"
Some checks failed
eden-license / license-header (pull_request) Failing after 30s
Details
91c923456b 
This reverts commit 75fda70db2.
CamilleLaVey approved these changes 2026-02-17 20:23:51 +01:00
Dismissed
CamilleLaVey left a comment
Owner
Copy link

This is reverted, because meowed image layout flags ✌️

This is reverted, because meowed image layout flags ✌️
LICENSES
Some checks failed
eden-license / license-header (pull_request) Failing after 30s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
a84361c367
Lizzie dismissed CamilleLaVey's review 2026-02-17 20:24:20 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

crueter requested changes 2026-02-17 20:28:36 +01:00
crueter left a comment
Owner
Copy link

Why? This brought plenty of extra performance.

Why? This brought plenty of extra performance.
CamilleLaVey commented 2026-02-17 21:15:37 +01:00
Owner
Copy link

It's a mali thing, doesn't handle all around commands for layouts, as other GPU's does, so increased performance only for Mali, based on Kleidis test.

It's a mali thing, doesn't handle all around commands for layouts, as other GPU's does, so increased performance only for Mali, based on Kleidis test.
DraVee commented 2026-02-18 06:57:41 +01:00
Member
Copy link

is this superseded by #3572 and #3573? or is unrelated?

is this superseded by #3572 and #3573? or is unrelated?
Lizzie commented 2026-02-18 19:51:21 +01:00
Author
Member
Copy link

@DraVee wrote in #3571 (comment):

is this superseded by #3572 and #3573? or is unrelated?

Unrelated

@DraVee wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/3571#issuecomment-20492: > is this superseded by #3572 and #3573? or is unrelated? Unrelated
CamilleLaVey commented 2026-02-19 03:35:44 +01:00
Owner
Copy link

@eden-emu/Triage

@eden-emu/Triage
CamilleLaVey deleted branch lizzie/revert-evil-mali 2026-02-19 04:07:46 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
MrPurple666
MaranBr
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3571
No description provided.