[compat] fix freebsd mmap virtual base #354

Merged

Lizzie merged 1 commit from liz-fix-fbsd-mmap-t into master

2025-08-30 17:03:57 +02:00

Lizzie commented

2025-08-30 01:51:59 +02:00

Member

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Shinmegumi requested changes 2025-08-30 02:16:03 +02:00

Dismissed

Shinmegumi left a comment

Owner

Are you sure this will work without being encapsulated in { } for your if (virtual_base) statement? Wasn't intended to be a change request.

Lizzie commented

2025-08-30 02:24:32 +02:00

Author

Member

@Shinmegumi wrote in #354 (comment):

Are you sure this will work without being encapsulated in { } for your if (virtual_base) statement? Wasn't intended to be a change request.

C++ grammar:

if (thing) {
  statment(1);
}
statment(2);

is equivalent to

if (thing)
  statment(1);
statment(2);

@Shinmegumi wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/354#issuecomment-2687: > Are you sure this will work without being encapsulated in { } for your if (virtual_base) statement? Wasn't intended to be a change request. C++ grammar: ```c++ if (thing) { statment(1); } statment(2); ``` is equivalent to ```c++ if (thing) statment(1); statment(2); ```

Lizzie force-pushed liz-fix-fbsd-mmap-t from d82f21ab5a to dbe4c36015

2025-08-30 07:56:54 +02:00

Compare

Shinmegumi force-pushed liz-fix-fbsd-mmap-t from dbe4c36015 to eff9f104d0

2025-08-30 16:36:12 +02:00

Compare

Shinmegumi approved these changes 2025-08-30 16:36:25 +02:00