eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[gamemode] Make available on other platforms #353

Open
Lizzie wants to merge 7 commits from liz-gamemode-flatten into master
pull from: liz-gamemode-flatten
merge into: eden-emu:master
Conversation 3 Commits 7 Files changed 15 +113 -495
Lizzie commented 2025-08-30 01:46:09 +02:00
Member
Copy link

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-08-30 01:46:09 +02:00
[gamemode] Make available on other platforms
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
3183f51e1f 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed liz-gamemode-flatten from 3183f51e1f to 385debd86b 2025-08-30 01:48:42 +02:00 Compare
Lizzie added 1 commit 2025-08-30 02:04:49 +02:00
[gamemode] make option available on all nixes
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
eae7801d0f 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed liz-gamemode-flatten from eae7801d0f to b19a9bced6 2025-08-30 07:57:01 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from b19a9bced6 to 26db1fb807 2025-08-30 10:44:11 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 26db1fb807 to 012d0d48ae 2025-08-30 15:39:40 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 012d0d48ae to 05db2ae62f 2025-08-30 15:41:21 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 05db2ae62f to a39181a370 2025-08-31 05:13:18 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from a39181a370 to 769403dfe5 2025-09-06 10:06:42 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 769403dfe5 to bb58b73fe5 2025-09-09 05:17:16 +02:00 Compare
crueter requested changes 2025-09-09 05:50:37 +02:00
crueter left a comment
Owner
Copy link

We should also move the gamemode option elsewhere in the UI maybe

We should also move the gamemode option elsewhere in the UI maybe
externals/gamemode/gamemode_client.h Outdated
@ -1,3 +4,3 @@
/*
Copyright (c) 2017-2019, Feral Interactive
Copyright (c) 2017-2025, Feral Interactive and the GameMode contributors
crueter commented 2025-09-09 05:50:06 +02:00
Owner
Copy link

Should this be vendored?

Should this be vendored?
Lizzie commented 2025-09-09 05:51:36 +02:00
Author
Member
Copy link

Feral interactive has updated gamemode a total of 1 time ever since the emu came out.
Feel free to vendor it with CMake magic - I'm unsure how through

Feral interactive has updated gamemode a total of 1 time ever since the emu came out. Feel free to vendor it with CMake magic - I'm unsure how through
crueter commented 2025-09-09 05:53:50 +02:00
Owner
Copy link

Send me the link to where you got it and I'll vendor it tomorrow

Send me the link to where you got it and I'll vendor it tomorrow
Lizzie commented 2025-09-09 05:55:20 +02:00
Author
Member
Copy link

@crueter wrote in #353 (comment):

Send me the link to where you got it and I'll vendor it tomorrow

https://github.com/FeralInteractive/gamemode/blob/master/lib/gamemode_client.h

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/353#issuecomment-3312: > Send me the link to where you got it and I'll vendor it tomorrow https://github.com/FeralInteractive/gamemode/blob/master/lib/gamemode_client.h
Lizzie force-pushed liz-gamemode-flatten from bb58b73fe5 to 5772537164 2025-09-13 22:49:09 +02:00 Compare
Shinmegumi commented 2025-09-15 17:00:14 +02:00
Owner
Copy link

@crueter, has this change been done to have this vendored so this can be merged? Since it only really affects BSD and such, it should be safe to merge. Will approve if the change has been made for this to be included in CMake properly.

@crueter, has this change been done to have this vendored so this can be merged? Since it only really affects BSD and such, it should be safe to merge. Will approve if the change has been made for this to be included in CMake properly.
Shinmegumi force-pushed liz-gamemode-flatten from 5772537164 to 63b9d22235 2025-09-15 17:00:20 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 63b9d22235 to e662fe99ac 2025-09-19 08:56:50 +02:00 Compare
Shinmegumi approved these changes 2025-09-20 17:30:46 +02:00
Dismissed
crueter force-pushed liz-gamemode-flatten from e662fe99ac to 0bd4f2bbd2 2025-09-27 01:30:30 +02:00 Compare
crueter dismissed Shinmegumi's review 2025-09-27 01:30:31 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie force-pushed liz-gamemode-flatten from 0bd4f2bbd2 to 929de88588 2025-09-29 06:42:02 +02:00 Compare
Lizzie added 1 commit 2025-09-29 09:49:03 +02:00
fix licsense
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
33a1355caa 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed liz-gamemode-flatten from 33a1355caa to eac3addacc 2025-09-29 18:54:50 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from eac3addacc to a6ad57078c 2025-09-30 10:35:44 +02:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Required
Details
This pull request has changes conflicting with the target branch.
  • CMakeLists.txt
  • externals/cpmfile.json
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin liz-gamemode-flatten:liz-gamemode-flatten
git checkout liz-gamemode-flatten
Sign in to join this conversation.
Reviewers
No reviewers
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#353
No description provided.
Delete branch "liz-gamemode-flatten"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?