eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[core] inline pointers to avoid uneeded allocs (lto fails to heap ellide) #3284

Closed
Lizzie wants to merge 1 commit from lizzie/core-inline-optional-ptr into master
pull from: lizzie/core-inline-optional-ptr
merge into: eden-emu:master
Conversation 1 Commits 1 Files changed 3 +66 -130
Lizzie commented 2026-01-09 06:05:35 +01:00
Member
Copy link
  • inlines stuff into std::optional<> as opposed to std::unique_ptr<> (because yknow, we are making the Impl from an unique_ptr, allocating within an allocation is unnecessary)
  • reorganizes the structures a bit so padding doesnt screw us up (it's not perfect but eh saves a measly 44 bytes)
  • removes unused/dead code
  • uses std::vector<> instead of std::deque<>

no perf impact expected, maybe some initialisation boost but very minimal impact nonethless
lto gets rid of most calls anyways - the heavy issue is with shared_ptr and the cache coherency from the atomics... but i clumped them together because well, they kinda do not suffer from cache coherency - hopefully not a mistake

this balloons the size of Impl to about 1.67 MB - which is fine because we throw it in the stack anyways

Signed-off-by: lizzie lizzie@eden-emu.dev

- inlines stuff into std::optional<> as opposed to std::unique_ptr<> (because yknow, we are making the Impl from an unique_ptr, allocating within an allocation is unnecessary) - reorganizes the structures a bit so padding doesnt screw us up (it's not perfect but eh saves a measly 44 bytes) - removes unused/dead code - uses std::vector<> instead of std::deque<> no perf impact expected, maybe some initialisation boost but very minimal impact nonethless lto gets rid of most calls anyways - the heavy issue is with shared_ptr and the cache coherency from the atomics... but i clumped them together because well, they kinda do not suffer from cache coherency - hopefully not a mistake this balloons the size of Impl to about 1.67 MB - which is fine because we throw it in the stack anyways Signed-off-by: lizzie <lizzie@eden-emu.dev>
DraVee force-pushed lizzie/core-inline-optional-ptr from 691b834645
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 7e88ff2483
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2026-01-11 05:07:12 +01:00 Compare
DraVee added this to the 0.2.0 milestone 2026-01-11 05:47:49 +01:00
DraVee force-pushed lizzie/core-inline-optional-ptr from 7e88ff2483
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to da4e484922
All checks were successful
eden-license / license-header (pull_request) Successful in 2m11s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2026-01-13 19:25:29 +01:00 Compare
Lizzie force-pushed lizzie/core-inline-optional-ptr from da4e484922
All checks were successful
eden-license / license-header (pull_request) Successful in 2m11s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 09fd1672c8
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2026-01-15 06:04:48 +01:00 Compare
Lizzie closed this pull request 2026-01-15 10:53:29 +01:00
DraVee commented 2026-01-15 13:37:47 +01:00
Member
Copy link

What happened?

What happened?
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
crueter
MrPurple666
MaranBr
CamilleLaVey
Maufeat
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
0.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3284
No description provided.