eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[moltenVK] MacOS SpirV to msl format fix #3277

Closed
chrelliott978 wants to merge 4 commits from chrelliott978/eden:master into master
pull from: chrelliott978/eden:master
merge into: eden-emu:master
Conversation 10 Commits 4 Files changed 3 +68 -2
chrelliott978 commented 2026-01-07 03:54:01 +01:00
First-time contributor
Copy link

Geometry issues present, but more games launch on MacOS now

  • Fixed runtime_info.h to properly guard VkFormat usage with #ifdef APPLE
  • Fixed MoltenVK subgroup scope errors in SPIR-V emission
  • Various pipeline cache updates for integer render target support
Geometry issues present, but more games launch on MacOS now * Fixed runtime_info.h to properly guard VkFormat usage with #ifdef APPLE * Fixed MoltenVK subgroup scope errors in SPIR-V emission * Various pipeline cache updates for integer render target support
chrelliott978 force-pushed master from 22ec0b407f
Some checks failed
GitHub Actions [CI] Build failed
Details
eden-license / license-header (pull_request) Has been cancelled
Details
to 3d0730a7d8
Some checks failed
GitHub Actions [CI] Build failed
Details
eden-license / license-header (pull_request) Has been cancelled
Details
2026-01-07 06:31:01 +01:00 Compare
chrelliott978 closed this pull request 2026-01-07 06:31:53 +01:00
DraVee commented 2026-01-07 06:39:24 +01:00
Member
Copy link

Why closed?

Why closed?
chrelliott978 commented 2026-01-07 06:53:10 +01:00
Author
First-time contributor
Copy link

@DraVee wrote in #3277 (comment):

Why closed?

i closed this one erroneously

@DraVee wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/3277#issuecomment-15826: > Why closed? i closed this one erroneously
DraVee commented 2026-01-07 06:53:29 +01:00
Member
Copy link

@chrelliott978 wrote in #3277 (comment):

@DraVee wrote in #3277 (comentário):

Why closed?

i closed this one erroneously

No problem

@chrelliott978 wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/3277#issuecomment-15850: > @DraVee wrote in #3277 (comentário): > > > Why closed? > > i closed this one erroneously No problem
chrelliott978 reopened this pull request 2026-01-07 06:54:08 +01:00
chrelliott978 commented 2026-01-07 23:44:17 +01:00
Author
First-time contributor
Copy link

@DraVee There's a merge conflict in vk_pipeline_cache.cpp because upstream master has been updated since I started this PR. Since I don't have a local clone of the repository, would you be able to help resolve the conflict and merge? The main changes in my PR are:

  1. Fixed runtime_info.h to properly guard VkFormat usage with #ifdef APPLE
  2. Fixed MoltenVK subgroup scope errors in SPIR-V emission
  3. Various pipeline cache updates for integer render target support

I've enabled "Allow edits from maintainers" so you should be able to push conflict resolutions to my branch if needed. Thank you!

@DraVee There's a merge conflict in vk_pipeline_cache.cpp because upstream master has been updated since I started this PR. Since I don't have a local clone of the repository, would you be able to help resolve the conflict and merge? The main changes in my PR are: 1. Fixed runtime_info.h to properly guard VkFormat usage with #ifdef __APPLE__ 2. Fixed MoltenVK subgroup scope errors in SPIR-V emission 3. Various pipeline cache updates for integer render target support I've enabled "Allow edits from maintainers" so you should be able to push conflict resolutions to my branch if needed. Thank you!
👍 1
DraVee force-pushed master from 139f41ef9f
Some checks failed
GitHub Actions [CI] Build failed
Details
eden-license / license-header (pull_request) Has been cancelled
Details
to 0e3dcd69cc
Some checks reported errors
eden-license / license-header (pull_request) Failing after 32s
Details
GitHub Actions [CI] Build cancelled
Details
2026-01-07 23:56:50 +01:00 Compare
DraVee force-pushed master from 0e3dcd69cc
Some checks reported errors
eden-license / license-header (pull_request) Failing after 32s
Details
GitHub Actions [CI] Build cancelled
Details
to 6745703939
Some checks reported errors
eden-license / license-header (pull_request) Failing after 33s
Details
GitHub Actions [CI] Build cancelled
Details
2026-01-07 23:57:19 +01:00 Compare
DraVee commented 2026-01-07 23:57:37 +01:00
Member
Copy link

@chrelliott978 wrote in #3277 (comment):

@DraVee There's a merge conflict in vk_pipeline_cache.cpp because upstream master has been updated since I started this PR. Since I don't have a local clone of the repository, would you be able to help resolve the conflict and merge? The main changes in my PR are:

1. Fixed runtime_info.h to properly guard VkFormat usage with #ifdef **APPLE**

2. Fixed MoltenVK subgroup scope errors in SPIR-V emission

3. Various pipeline cache updates for integer render target support

I've enabled "Allow edits from maintainers" so you should be able to push conflict resolutions to my branch if needed. Thank you!

Fixed

@chrelliott978 wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/3277#issuecomment-15912: > @DraVee There's a merge conflict in vk_pipeline_cache.cpp because upstream master has been updated since I started this PR. Since I don't have a local clone of the repository, would you be able to help resolve the conflict and merge? The main changes in my PR are: > > 1. Fixed runtime_info.h to properly guard VkFormat usage with #ifdef **APPLE** > > 2. Fixed MoltenVK subgroup scope errors in SPIR-V emission > > 3. Various pipeline cache updates for integer render target support > > > I've enabled "Allow edits from maintainers" so you should be able to push conflict resolutions to my branch if needed. Thank you! Fixed
DraVee changed title from WIP: MacOS spirv to msl format fix to WIP: [moltenVK] MacOS SpirV to msl format fix 2026-01-07 23:59:38 +01:00
DraVee added this to the 0.2.0 milestone 2026-01-11 05:49:15 +01:00
DraVee changed title from WIP: [moltenVK] MacOS SpirV to msl format fix to [moltenVK] MacOS SpirV to msl format fix 2026-01-13 02:34:44 +01:00
DraVee approved these changes 2026-01-13 02:37:55 +01:00
Dismissed
MaranBr approved these changes 2026-01-13 02:45:55 +01:00
Dismissed
DraVee requested review from DraVee 2026-01-13 02:46:46 +01:00
chrelliott978 commented 2026-01-14 05:15:32 +01:00
Author
First-time contributor
Copy link

The following video shows certain games launching and running when they did not before:

https://youtu.be/0lgNH2N_AQ4

The following video shows certain games launching and running when they did not before: https://youtu.be/0lgNH2N_AQ4
chrelliott978 force-pushed master from 7b40eeeb84
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to c7cd2b9597
Some checks failed
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
eden-license / license-header (pull_request) Has been cancelled
Details
2026-01-14 05:15:52 +01:00 Compare
chrelliott978 dismissed DraVee's review 2026-01-14 05:15:52 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

chrelliott978 dismissed MaranBr's review 2026-01-14 05:15:52 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie force-pushed master from c7cd2b9597
Some checks failed
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
eden-license / license-header (pull_request) Has been cancelled
Details
to 804066fe56
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2026-01-15 04:10:07 +01:00 Compare
Lizzie approved these changes 2026-01-15 04:10:31 +01:00
CamilleLaVey commented 2026-01-15 04:23:26 +01:00
Owner
Copy link

This will pr has a wrong format table order and it's defaulting F32 behavior over other platforms, it will be required OP to work closely with team to reach a proper results into something that can be candidate to merge into project, for the time being, this PR will be closed.

This will pr has a wrong format table order and it's defaulting F32 behavior over other platforms, it will be required OP to work closely with team to reach a proper results into something that can be candidate to merge into project, for the time being, this PR will be closed.
CamilleLaVey closed this pull request 2026-01-15 04:23:27 +01:00
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
crueter
MrPurple666
DraVee
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
0.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3277
No description provided.