eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[tools/windows] fix Windows on ARM installs for vulkan #3201

Merged
crueter merged 4 commits from install-vulkan-ps1-fix-windows-on-arm into master 2026-02-05 22:44:09 +01:00
Conversation 10 Commits 4 Files changed 2 +23 -8
Lizzie commented 2025-12-25 07:44:57 +01:00
Member
Copy link

while we dont support MSVC on ARM64 yet, one day we may, and when that day comes someone will be annoyed their vulkan sdk won't install properly

Signed-off-by: lizzie lizzie@eden-emu.dev

while we dont support MSVC on ARM64 yet, one day we may, and when that day comes someone will be annoyed their vulkan sdk won't install properly Signed-off-by: lizzie lizzie@eden-emu.dev
DraVee approved these changes 2025-12-25 14:10:52 +01:00
Dismissed
DraVee requested review from DraVee 2025-12-26 01:11:18 +01:00
DraVee force-pushed install-vulkan-ps1-fix-windows-on-arm from 157d6ee13f
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to d4d730b2b0
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-12-26 01:14:47 +01:00 Compare
DraVee dismissed DraVee's review 2025-12-26 01:14:48 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

DraVee approved these changes 2025-12-26 01:47:38 +01:00
Dismissed
crueter requested changes 2025-12-26 02:37:58 +01:00
Dismissed
tools/windows/install-vulkan-sdk.sh Outdated
@ -6,2 +6,3 @@
: "${VULKAN_ROOT:=C:/VulkanSDK/$VULKAN_SDK_VER}"
EXE_FILE="vulkansdk-windows-X64-$VULKAN_SDK_VER.exe"
VULKAN_SDK_ARCH="X64"
if [[ $(uname) == *"ARM64"* ]]; then
crueter commented 2025-12-26 02:37:56 +01:00
Owner
Copy link

Please don't use bash-isms, prefer case instead:

case "$(uname -m)" in
    x86_64) arch=X64 ;;
    arm*|aarch*) arch=ARM64 ;;
esac
Please don't use bash-isms, prefer case instead: ```sh case "$(uname -m)" in x86_64) arch=X64 ;; arm*|aarch*) arch=ARM64 ;; esac ```
Lizzie commented 2025-12-26 06:23:42 +01:00
Author
Member
Copy link

m doesn't return ARM64/X64 iirc, it returns x86_64 even on clangarm64

m doesn't return ARM64/X64 iirc, it returns x86_64 even on clangarm64
crueter commented 2025-12-26 06:48:21 +01:00
Owner
Copy link

What the fuck

What the fuck
crueter marked this conversation as resolved
crueter requested changes 2025-12-29 01:55:52 +01:00
Dismissed
tools/windows/install-vulkan-sdk.sh Outdated
@ -8,0 +7,4 @@
VULKAN_SDK_ARCH="X64"
if [[ $(uname) == *"ARM64"* ]]; then
VULKAN_SDK_ARCH="ARM64"
fi
crueter commented 2025-12-29 01:55:47 +01:00
Owner
Copy link
arch=X64
case "$(uname)" in
    *ARM64*) arch=ARM64 ;;
esac
```sh arch=X64 case "$(uname)" in *ARM64*) arch=ARM64 ;; esac ```
crueter marked this conversation as resolved
Lizzie dismissed DraVee's review 2025-12-29 02:30:57 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

crueter commented 2026-01-20 17:18:08 +01:00
Owner
Copy link

https://sdk.lunarg.com/sdk/download/1.4.335.0/windows/vulkansdk-windows-X64-1.4.335.0.exe
https://sdk.lunarg.com/sdk/download/1.4.335.0/warm/vulkansdk-windows-ARM64-1.4.335.0.exe

You will additionally have to modify the parameter immediately after the version.

https://sdk.lunarg.com/sdk/download/1.4.335.0/windows/vulkansdk-windows-X64-1.4.335.0.exe https://sdk.lunarg.com/sdk/download/1.4.335.0/warm/vulkansdk-windows-ARM64-1.4.335.0.exe You will additionally have to modify the parameter immediately after the version.
Lizzie force-pushed install-vulkan-ps1-fix-windows-on-arm from 07254bcefb
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to fa9711458d
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
2026-01-30 11:54:20 +01:00 Compare
DraVee commented 2026-02-02 19:02:49 +01:00
Member
Copy link

Can we merge it?

Can we merge it?
crueter commented 2026-02-05 05:12:20 +01:00
Owner
Copy link

Update to 1.4.341.1 while we're at it and it should be good.

Update to 1.4.341.1 while we're at it and it should be good.
Lizzie force-pushed install-vulkan-ps1-fix-windows-on-arm from fa9711458d
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
to 8fed4fab66
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
2026-02-05 22:37:33 +01:00 Compare
crueter approved these changes 2026-02-05 22:38:01 +01:00
DraVee approved these changes 2026-02-05 22:42:58 +01:00
Dismissed
Lizzie force-pushed install-vulkan-ps1-fix-windows-on-arm from 8fed4fab66
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
to 1fdd34f2c3
Some checks are pending
eden-license / license-header (pull_request) Successful in 23s
Details
GitHub Actions [CI] Build started
Details
2026-02-05 22:43:39 +01:00 Compare
DraVee approved these changes 2026-02-05 22:43:55 +01:00
crueter merged commit 8907523ee4 into master 2026-02-05 22:44:09 +01:00
crueter deleted branch install-vulkan-ps1-fix-windows-on-arm 2026-02-05 22:44:10 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
MaranBr
CamilleLaVey
Maufeat
MrPurple666
crueter
DraVee
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3201
No description provided.