eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[qt] remove full/empty filters, replace with public lobby filter #3136

Open
Lizzie wants to merge 1 commit from mutliplayer-filter-better1 into master
pull from: mutliplayer-filter-better1
merge into: eden-emu:master
Conversation 5 Commits 1 Files changed 4 +29 -78
Lizzie commented 2025-12-03 03:10:23 +01:00
Member
Copy link
  • full/empty checkboxes are redundant
  • nobody in the world uses those checkboxes
  • people would rather see if the lobby is password protected OR public
  • if you want to see empty/full lobbies, just sort them by player count
    Signed-off-by: lizzie lizzie@eden-emu.dev
- full/empty checkboxes are redundant - nobody in the world uses those checkboxes - people would rather see if the lobby is password protected OR public - if you want to see empty/full lobbies, just sort them by player count Signed-off-by: lizzie <lizzie@eden-emu.dev>
[qt] remove full/empty filters, replace with public lobby filter"
All checks were successful
eden-license / license-header (pull_request) Successful in 15s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
795a52c75a
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
crueter commented 2025-12-03 03:12:36 +01:00
Owner
Copy link

full/empty checkboxes are redundant

They aren't. Just make them on by default.

> full/empty checkboxes are redundant They aren't. Just make them on by default.
Lizzie commented 2025-12-03 03:20:04 +01:00
Author
Member
Copy link

@crueter wrote in #3136 (comment):

full/empty checkboxes are redundant

They aren't. Just make them on by default.

I think users may prefer to see if a lobby is password protected or not, as opposed to it being full/empty, since the sorting function already kinda accomplishes that task

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/3136#issuecomment-13264: > > full/empty checkboxes are redundant > > They aren't. Just make them on by default. I *think* users may prefer to see if a lobby is password protected or not, as opposed to it being full/empty, since the sorting function already kinda accomplishes that task
DraVee commented 2026-01-11 05:40:35 +01:00
Member
Copy link

Does this will be merged?

Does this will be merged?
DraVee commented 2026-02-09 21:37:02 +01:00
Member
Copy link

I think Public Rooms should be off by default (so we can see everything)

I think Public Rooms should be off by default (so we can see everything)
DraVee commented 2026-02-09 21:37:49 +01:00
Member
Copy link

Or invert the logic, Private Rooms and make it On by default

Or invert the logic, Private Rooms and make it On by default
All checks were successful
eden-license / license-header (pull_request) Successful in 15s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mutliplayer-filter-better1:mutliplayer-filter-better1
git switch mutliplayer-filter-better1
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
crueter
MrPurple666
MaranBr
CamilleLaVey
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3136
No description provided.