eden-emu/eden
24
3
Fork 18
Code Issues 90 Pull requests 75 Projects 1 Releases 7 Wiki Activity Actions

[host_memory] remove unused fastmem fallback path #3133

Open
Lizzie wants to merge 2 commits from remove-unused-fastmem-fallback into master
pull from: remove-unused-fastmem-fallback
merge into: eden-emu:master
Conversation 0 Commits 2 Files changed 2 +15 -29
Lizzie commented 2025-12-03 02:29:44 +01:00
Member
Copy link

basically nobody ever used that path, we instead soft-crash upon not being able to allocate backing storage, we do still attempt to allocate a virtual base through, but if backing storage fails for any reason whatsoever, we pretty much cant run the emulator anyways

Signed-off-by: lizzie lizzie@eden-emu.dev

basically nobody ever used that path, we instead soft-crash upon not being able to allocate **backing** storage, we do still attempt to allocate a virtual base through, but if backing storage fails for any reason whatsoever, we pretty much cant run the emulator anyways Signed-off-by: lizzie <lizzie@eden-emu.dev>
[host_memory] remove unused fastmem fallback path
Some checks failed
eden-license / license-header (pull_request) Failing after 15s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
c90c277909
 
basically nobody ever used that path, we instead soft-crash upon not being able to allocate **backing** storage, we do still attempt to allocate a virtual base through, but if backing storage fails for any reason whatsoever, we pretty much cant run the emulator anyways

Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed remove-unused-fastmem-fallback from c90c277909
Some checks failed
eden-license / license-header (pull_request) Failing after 15s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 35e7bd4637
All checks were successful
eden-license / license-header (pull_request) Successful in 17s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-12-04 01:46:26 +01:00 Compare
DraVee force-pushed remove-unused-fastmem-fallback from 35e7bd4637
All checks were successful
eden-license / license-header (pull_request) Successful in 17s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 361f543479
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-12-04 18:20:13 +01:00 Compare
DraVee force-pushed remove-unused-fastmem-fallback from 361f543479
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 3415903714
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-12-09 21:02:19 +01:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin remove-unused-fastmem-fallback:remove-unused-fastmem-fallback
git switch remove-unused-fastmem-fallback
Sign in to join this conversation.
Reviewers
No reviewers
MaranBr
CamilleLaVey
Maufeat
crueter
MrPurple666
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3133
No description provided.