eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 55 Projects 1 Releases Packages Wiki Activity Actions

WIP: [cmake, doc] update CMake/docs for macOS #310

Closed
Lizzie wants to merge 8 commits from macosfixesxcode1 into master
pull from: macosfixesxcode1
merge into: eden-emu:master
Conversation 5 Commits 8 Files changed 8 +140 -79
Lizzie commented 2025-08-25 09:49:47 +02:00
Member
Copy link
No description provided.
Lizzie added 2 commits 2025-08-25 09:49:47 +02:00 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
[macOS] fix mbedtls
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
0fb70936d9 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-08-25 10:15:06 +02:00
[cmake] force bundled mbedtls (for apple?)
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
Details
ec3928915e 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
crueter approved these changes 2025-08-25 14:42:23 +02:00
Dismissed
crueter left a comment
Owner
Copy link

I meant to make mbedtls bundled anyways, since mbedtls3 is incompatible and mbedtls2 uses pkgconfig

I meant to make mbedtls bundled anyways, since mbedtls3 is incompatible and mbedtls2 uses pkgconfig
crueter changed title from WIP: fix macOS to [cmake, doc] update CMake/docs for macOS 2025-08-25 17:22:57 +02:00
crueter added 1 commit 2025-08-25 17:30:49 +02:00
[cmake] fix zstd link
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
dd636464d4 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter dismissed crueter's review 2025-08-25 17:30:49 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Shinmegumi commented 2025-08-25 17:40:37 +02:00
Owner
Copy link

Need to cd build after using cmake in the eden directory then run the ninja command in terminal. Otherwise, it gives you an error about build.ninja not being found.

Need to cd build after using cmake in the eden directory then run the ninja command in terminal. Otherwise, it gives you an error about build.ninja not being found.
crueter added 1 commit 2025-08-25 17:40:50 +02:00
[cmake] use MODULE for non-CPM zstd
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
5d3cf78351 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-25 17:48:51 +02:00
[cmake] fix opus link
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
3e56e548a6 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-25 18:51:35 +02:00
[cmake] force external spirv-tools on apple, fix findpkg logic
All checks were successful
eden-license / license-header (pull_request) Successful in 41s
Details
a24047b962 
Signed-off-by: crueter <crueter@eden-emu.dev>
Lizzie commented 2025-08-26 02:52:12 +02:00
Author
Member
Copy link

@Shinmegumi wrote in #310 (comment):

Need to cd build after using cmake in the eden directory then run the ninja command in terminal. Otherwise, it gives you an error about build.ninja not being found.

Must replace with cmake --build build -- -j$(nproc)

@Shinmegumi wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/310#issuecomment-2318: > Need to cd build after using cmake in the eden directory then run the ninja command in terminal. Otherwise, it gives you an error about build.ninja not being found. Must replace with `cmake --build build -- -j$(nproc)`
crueter added 1 commit 2025-08-26 19:46:15 +02:00
[cmake] force bundled zstd on Apple
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
406cc71291 
Signed-off-by: crueter <crueter@eden-emu.dev>
Lizzie force-pushed macosfixesxcode1 from 406cc71291 to 43f040ff40 2025-08-30 01:57:50 +02:00 Compare
Lizzie force-pushed macosfixesxcode1 from 43f040ff40 to eba6855fd9 2025-08-30 07:57:18 +02:00 Compare
crueter commented 2025-09-02 16:13:49 +02:00
Owner
Copy link

This is heavily outdated, needs updated for cpmfile.

This is heavily outdated, needs updated for cpmfile.
crueter changed title from [cmake, doc] update CMake/docs for macOS to WIP: [cmake, doc] update CMake/docs for macOS 2025-09-02 16:13:52 +02:00
crueter commented 2025-09-08 00:45:10 +02:00
Owner
Copy link

superseded by #392

superseded by #392
crueter closed this pull request 2025-09-08 00:45:10 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#310
No description provided.
Delete branch "macosfixesxcode1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?