eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[gpu/NVDRV] Finalize AllocObjCtx #308

Closed
SDK-Chan wants to merge 4 commits from finalize-allocObjCtx into master
pull from: finalize-allocObjCtx
merge into: eden-emu:master
Conversation 1 Commits 4 Files changed 1 +23 -3
SDK-Chan commented 2025-08-25 09:20:29 +02:00
Member
Copy link

Added some needed checks.
Added release functionality for object context once not needed anymore.
Added a scoped_lock for the channel_mutex as a kind of a safe guard against unpredictable situations.

Added some needed checks. Added release functionality for object context once not needed anymore. Added a scoped_lock for the channel_mutex as a kind of a safe guard against unpredictable situations.
SDK-Chan added 1 commit 2025-08-25 09:20:29 +02:00
[gpu/NVDRV] Finalize AllocObjCtx
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
d27b787f03
Lizzie reviewed 2025-08-25 09:23:38 +02:00
src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp Outdated
@ -221,3 +223,3 @@
NvResult nvhost_gpu::AllocateObjectContext(IoctlAllocObjCtx& params) {
LOG_DEBUG(Service_NVDRV, "called, class_num={:X}, flags={:X}, obj_id={:X}", params.class_num,
LOG_DEBUG(Service_NVDRV, "called, class_num=0x{:X}, flags=0x{:X}, obj_id=0x{:X}", params.class_num,
Lizzie commented 2025-08-25 09:23:38 +02:00
Member
Copy link

Do not use 0x{:X}, use {:#X} instead

Do not use `0x{:X}`, use `{:#X}` instead
SDK-Chan marked this conversation as resolved
SDK-Chan added 1 commit 2025-08-25 09:47:27 +02:00
Update src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
4e7d6809f9
SDK-Chan added 1 commit 2025-08-25 10:18:45 +02:00
Update src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
1595ca113b
SDK-Chan added 1 commit 2025-08-25 17:53:43 +02:00
Update src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
29ef4800cc
crueter closed this pull request 2025-08-27 15:13:09 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#308
No description provided.
Delete branch "finalize-allocObjCtx"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?