[service, ns, acc] Stub IsQualificationTransitionSupportedByProcessId and SaveDataThumbnail commands #299

Closed
JPikachu wants to merge 1 commit from borderlands-services into master
Member
  • ns: Stubbed IsQualificationTransitionSupportedByProcessId (2520) to always return true.
  • acc: added the missing SaveDataThumbnail commands:
    • ClearSaveDataThumbnail (111) → stubbed, returns success.
    • LoadSaveDataThumbnail (112) → stubbed, returns success with dummy thumbnail.
    • GetSaveDataThumbnailExistence (113) → stubbed, returns true.
- ns: Stubbed IsQualificationTransitionSupportedByProcessId (2520) to always return true. - acc: added the missing SaveDataThumbnail commands: * ClearSaveDataThumbnail (111) → stubbed, returns success. * LoadSaveDataThumbnail (112) → stubbed, returns success with dummy thumbnail. * GetSaveDataThumbnailExistence (113) → stubbed, returns true.
JPikachu added 1 commit 2025-08-22 01:06:23 +02:00
[service, ns, acc] Stub IsQualificationTransitionSupportedByProcessId and SaveDataThumbnail commands
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
de6a1132d4
- ns: Stubbed IsQualificationTransitionSupportedByProcessId (2520) to always return true.
- acc: added the missing SaveDataThumbnail commands:
  * ClearSaveDataThumbnail (111) → stubbed, returns success.
  * LoadSaveDataThumbnail (112) → stubbed, returns success with size=0.
  * GetSaveDataThumbnailExistence (113) → stubbed, returns false.

This allows titles like Borderlands GOTY to progress past save-related errors.
JPikachu added 1 commit 2025-08-22 14:09:58 +02:00
Fix "Not a Member" build errors
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
be4d4458d8
This better work or else I will have to work out how to build again on Mac 😅
JPikachu force-pushed borderlands-services from be4d4458d8 to 07581a2161 2025-08-24 17:03:22 +02:00 Compare
JPikachu force-pushed borderlands-services from 07581a2161 to 3b18de150e 2025-08-25 00:01:30 +02:00 Compare
Author
Member

removing "This allows titles like Borderlands GOTY to progress past save-related errors." as the save error will most likely need a different type of fix. It needs to be chosen wether or not we still want these new stubs though.

removing "This allows titles like Borderlands GOTY to progress past save-related errors." as the save error will most likely need a different type of fix. It needs to be chosen wether or not we still want these new stubs though.
Lizzie reviewed 2025-08-25 01:19:58 +02:00
@ -1111,0 +1118,4 @@
void Module::Interface::LoadSaveDataThumbnail(HLERequestContext& ctx) {
// TODO: Grab thumbnail from Nand so this can be unstubbed
// For now, pretend a thumbnail exists and return dummy data
std::vector<u8> dummy_thumbnail(THUMBNAIL_SIZE, 0);
Member

Use boost::static_vector, or std::array, maybe?

Use boost::static_vector, or std::array, maybe?
Author
Member

Thank you @Lizzie for the suggestion, I will close this PR to clean it up a little in the branch and use this advice in my full (not stubbed) implementation.

Thank you @Lizzie for the suggestion, I will close this PR to clean it up a little in the branch and use this advice in my full (not stubbed) implementation.
JPikachu closed this pull request 2025-08-25 17:37:32 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Required
Details

Pull request closed

Sign in to join this conversation.
No description provided.