eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk] Fix fallback viewport/scissor origin handling #294

Open
Shinmegumi wants to merge 2 commits from viewport-fallback into master
pull from: viewport-fallback
merge into: eden-emu:master
Conversation 1 Commits 2 Files changed 2 +29 -20
Shinmegumi commented 2025-08-21 21:38:56 +02:00
Owner
Copy link

When viewport_scale_offset_enabled is disabled, the fallback path
previously assumed a top-left origin for both viewport and scissor.
This caused incorrect positioning or inverted geometry when the GPU
state expected a lower-left origin.

This change:

  • Adjusts viewport setup: if window_origin is lower-left, shift Y and
    flip height negative to emulate lower-left in Vulkan’s top-left space.
  • Updates scissor setup: recalculates Y for lower-left origin and
    ensures width/height fall back to 1 if zero, avoiding invalid extents.

This aligns Vulkan’s viewport/scissor behavior with Maxwell state,
fixing rendering issues in paths without scale/offset enabled.

When viewport_scale_offset_enabled is disabled, the fallback path previously assumed a top-left origin for both viewport and scissor. This caused incorrect positioning or inverted geometry when the GPU state expected a lower-left origin. This change: - Adjusts viewport setup: if window_origin is lower-left, shift Y and flip height negative to emulate lower-left in Vulkan’s top-left space. - Updates scissor setup: recalculates Y for lower-left origin and ensures width/height fall back to 1 if zero, avoiding invalid extents. This aligns Vulkan’s viewport/scissor behavior with Maxwell state, fixing rendering issues in paths without scale/offset enabled.
Shinmegumi added 1 commit 2025-08-21 21:38:57 +02:00
[vk] Apply fallback patch for Viewport
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
52379c383d 
Will add details if this solves the issue we are testing for.
Shinmegumi changed title from [vk] Apply fallback patch for Viewport to [vk] Fix fallback viewport/scissor origin handling 2025-08-21 21:43:30 +02:00
Shinmegumi added 1 commit 2025-08-21 21:45:40 +02:00
[vk] Fix dynamic vertex input state handling
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
7571a36993 
Previously, UpdateVertexInput() was always called when
has_dynamic_vertex_input was true, even if the current graphics pipeline
was not created with VK_DYNAMIC_STATE_VERTEX_INPUT_EXT. This could lead
to unnecessary or invalid state updates.

This change:
- Adds GraphicsPipeline::HasDynamicVertexInput() to check whether the
  pipeline was created with dynamic vertex input enabled.
- Calls UpdateVertexInput() only when the current pipeline supports
  VK_DYNAMIC_STATE_VERTEX_INPUT_EXT.

This ensures vertex input state updates are applied only when valid,
improving correctness and preventing redundant updates.
Shinmegumi commented 2025-08-21 21:46:09 +02:00
Author
Owner
Copy link

Added a fix for Dynamic Vertex Input state handling as well.

Added a fix for Dynamic Vertex Input state handling as well.
Shinmegumi changed title from [vk] Fix fallback viewport/scissor origin handling to [vk] More vulkan fixes 2025-08-21 21:47:24 +02:00
Shinmegumi changed title from [vk] More vulkan fixes to [vk] Fix fallback viewport/scissor origin handling 2025-08-21 21:52:18 +02:00
Shinmegumi added 1 commit 2025-08-21 21:52:55 +02:00
revert 7571a36993
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
c1a9c6b1ca 
revert [vk] Fix dynamic vertex input state handling

Previously, UpdateVertexInput() was always called when
has_dynamic_vertex_input was true, even if the current graphics pipeline
was not created with VK_DYNAMIC_STATE_VERTEX_INPUT_EXT. This could lead
to unnecessary or invalid state updates.

This change:
- Adds GraphicsPipeline::HasDynamicVertexInput() to check whether the
  pipeline was created with dynamic vertex input enabled.
- Calls UpdateVertexInput() only when the current pipeline supports
  VK_DYNAMIC_STATE_VERTEX_INPUT_EXT.

This ensures vertex input state updates are applied only when valid,
improving correctness and preventing redundant updates.
MaranBr force-pushed viewport-fallback from c1a9c6b1ca to 194031096e 2025-09-28 16:36:35 +02:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin viewport-fallback:viewport-fallback
git checkout viewport-fallback
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#294
No description provided.
Delete branch "viewport-fallback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?