eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[core] Finalize AliasRegionExtraSize #291

Merged
CamilleLaVey merged 4 commits from finalize-aliasRegionExtraSize into master 2025-08-21 21:08:44 +02:00
Conversation 2 Commits 4 Files changed 4 +35 -14
SDK-Chan commented 2025-08-21 12:35:06 +02:00
Member
Copy link

The previous implementation was based on assumptions for the baseline.
The new implementation is based on calculations, and should be more robust for DRAM values beyond 8GB as well.

The previous implementation was based on assumptions for the baseline. The new implementation is based on calculations, and should be more robust for DRAM values beyond 8GB as well.
Lizzie approved these changes 2025-08-21 12:41:16 +02:00
Dismissed
src/core/hle/kernel/k_page_table_base.cpp Outdated
@ -293,0 +296,4 @@
const bool is_64bit_as = (as_type & as_mask) == Svc::CreateProcessFlag::AddressSpace64Bit;
if (is_64bit_as && (as_type & Svc::CreateProcessFlag::EnableAliasRegionExtraSize)
!= static_cast<Svc::CreateProcessFlag>(0) && alias_region_size) {
Lizzie commented 2025-08-21 12:38:53 +02:00
Member
Copy link

I'd say use Svc::CreateProcessFlag to invoke the implicit ctor instead of doing a static cast

I'd say use `Svc::CreateProcessFlag` to invoke the implicit ctor instead of doing a static cast
SDK-Chan commented 2025-08-21 12:59:27 +02:00
Author
Member
Copy link

Done.

Done.
SDK-Chan marked this conversation as resolved
SDK-Chan dismissed Lizzie's review 2025-08-21 12:58:55 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Shinmegumi approved these changes 2025-08-21 13:27:31 +02:00
CamilleLaVey force-pushed finalize-aliasRegionExtraSize from 97ba9aa152 to e8fb980751 2025-08-21 21:06:42 +02:00 Compare
CamilleLaVey merged commit e75ceb676b into master 2025-08-21 21:08:44 +02:00
CamilleLaVey deleted branch finalize-aliasRegionExtraSize 2025-08-21 21:08:45 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#291
No description provided.
Delete branch "finalize-aliasRegionExtraSize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?