eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 62 Projects 1 Releases Wiki Activity Actions

[dynarmic] simplify assert macro usage (Only ASSERT/DEBUG_ASSERT are needed) #2890

Open
Lizzie wants to merge 12 commits from assert-simplify-only-one-macro into master
pull from: assert-simplify-only-one-macro
merge into: eden-emu:master
Conversation 4 Commits 12 Files changed 65 +385 -429
Lizzie commented 2025-10-29 08:22:33 +01:00
Member
Copy link
  • replace instances of ASSERT() with those where UNREACHABLE() should be used instead
  • debuggers exist for a reason, you can't just debug an issue in dynarmic with just printing fancy text... you need to inspect values and alldat - while yes the asserts are "useful"; there is this beautiful thing called backtraces
  • this will indirectly speedup the main decoder loop because of the added UNREACHABLE()
  • this also removes a bunch of macros that were redundant
  • the weird trick of &{}() is really funky, just do what everyone has done for the past 30 years and use a do { <thing> } while(0) :)

I may or may not have missed one assert or messed up my regex substitutions...

Signed-off-by: lizzie lizzie@eden-emu.dev

- replace instances of ASSERT() with those where UNREACHABLE() should be used instead - debuggers exist for a reason, you can't just debug an issue in dynarmic with just printing fancy text... you need to inspect values and alldat - while yes the asserts are "useful"; there is this beautiful thing called backtraces - this will indirectly speedup the main decoder loop because of the added UNREACHABLE() - this also removes a bunch of macros that were redundant - the weird trick of [&](){}() is really funky, just do what everyone has done for the past 30 years and use a `do { <thing> } while(0)` :) I may or may not have missed one assert or messed up my regex substitutions... Signed-off-by: lizzie <lizzie@eden-emu.dev>
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Signed-off-by: lizzie <lizzie@eden-emu.dev>
better unreachables
Some checks failed
eden-license / license-header (pull_request) Failing after 30s
Details
GitHub Actions [CI] Build failed
Details
f376790ca1
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie changed title from [dynarmic] simplify assert macro usage (Only ASSERT/DEBUG_ASSERT are needed) to WIP: [dynarmic] simplify assert macro usage (Only ASSERT/DEBUG_ASSERT are needed) 2025-10-29 08:29:43 +01:00 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
oopsie
Some checks failed
eden-license / license-header (pull_request) Failing after 31s
Details
GitHub Actions [CI] Build failed
Details
383d7280cd
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
licenses :)
Some checks failed
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build failed
Details
6fea1f8847
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie changed title from WIP: [dynarmic] simplify assert macro usage (Only ASSERT/DEBUG_ASSERT are needed) to [dynarmic] simplify assert macro usage (Only ASSERT/DEBUG_ASSERT are needed) 2025-10-29 09:36:09 +01:00
Lizzie force-pushed assert-simplify-only-one-macro from 6fea1f8847
Some checks failed
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build failed
Details
to 2e2066979f
Some checks failed
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build failed
Details
2025-10-29 19:32:23 +01:00 Compare
fx
Some checks reported errors
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build cancelled
Details
561ea20520
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
OH MY GOD i love string concat
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
3de073818f
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
DraVee approved these changes 2025-10-30 16:48:44 +01:00
Dismissed
Shinmegumi approved these changes 2025-10-30 18:42:00 +01:00
Dismissed
crueter commented 2025-10-30 20:01:37 +01:00
Owner
Copy link

delete zydis from here because conflicts

delete zydis from here because conflicts
Lizzie force-pushed assert-simplify-only-one-macro from 3de073818f
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 4351bfa379
All checks were successful
eden-license / license-header (pull_request) Successful in 38s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-30 20:23:29 +01:00 Compare
Lizzie dismissed DraVee's review 2025-10-30 20:23:29 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie dismissed Shinmegumi's review 2025-10-30 20:23:29 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

DraVee approved these changes 2025-10-30 22:49:43 +01:00
All checks were successful
eden-license / license-header (pull_request) Successful in 38s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin assert-simplify-only-one-macro:assert-simplify-only-one-macro
git switch assert-simplify-only-one-macro
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
crueter
MrPurple666
MaranBr
DraVee
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2890
No description provided.