[VK] spec-clean MasterSemaphore submits #285

Merged

Shinmegumi merged 2 commits from mastersemaphore_specsafe into master

2025-08-23 20:00:58 +02:00

wildcard commented

2025-08-20 20:19:20 +02:00

Member

fixes this error [ 18.505526] Render.Vulkan video_core/vulkan_common/vulkan_debug_callback.cpp:DebugUtilCallback:59: Validation Information: [ UNASSIGNED-BestPractices-SemaphoreCount ] | MessageID = 0x6cfe18a5 | pSubmits[0].pWaitSemaphores is set, but pSubmits[0].waitSemaphoreCount is 0.
This patch is only corrective in nature and is trivial and should not fix or break anything just one of the best practices in vulkan. It nulls pWaitSemaphores / pWaitDstStageMask / pSignalSemaphores when the corresponding counts are zero.

fixes this error [ 18.505526] Render.Vulkan <Info> video_core/vulkan_common/vulkan_debug_callback.cpp:DebugUtilCallback:59: Validation Information: [ UNASSIGNED-BestPractices-SemaphoreCount ] | MessageID = 0x6cfe18a5 | pSubmits[0].pWaitSemaphores is set, but pSubmits[0].waitSemaphoreCount is 0. This patch is only corrective in nature and is trivial and should not fix or break anything just one of the best practices in vulkan. It nulls pWaitSemaphores / pWaitDstStageMask / pSignalSemaphores when the corresponding counts are zero.

Shinmegumi commented

2025-08-20 20:21:31 +02:00

Owner

This just fixes it so it doesn't spam logs and such in debugging mode right? Does this show up in the logs outside of GPU Debugging?

wildcard commented

2025-08-20 20:23:09 +02:00

Author

Member

@Shinmegumi wrote in #285 (comment):

This just fixes it so it doesn't spam logs and such in debugging mode right? Does this show up in the logs outside of GPU Debugging?

no this error does not show up in current master because of the validation layer does not have best practices enabled

@Shinmegumi wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/285#issuecomment-2090: > This just fixes it so it doesn't spam logs and such in debugging mode right? Does this show up in the logs outside of GPU Debugging? no this error does not show up in current master because of the validation layer does not have best practices enabled

Shinmegumi approved these changes 2025-08-23 20:00:26 +02:00

Shinmegumi force-pushed mastersemaphore_specsafe from f3d4c46622 to 116016137d

2025-08-23 20:00:32 +02:00

Compare