eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[cmake] refactor: SDL2 CI and CPMUtil::AddCIPackage #284

Merged
Shinmegumi merged 13 commits from feature/sdl2-ci into master 2025-08-23 19:42:50 +02:00
Conversation 4 Commits 13 Files changed 10 +281 -307
crueter commented 2025-08-20 19:32:51 +02:00
Owner
Copy link

Replaces bundled SDL2 with my SDL2 CI, and updates external SDL2

Additionally, reduces all that boilerplate with a common AddCIPackage in
CPMUtil.cmake, currently used by OpenSSL and SDL2. To be used with ffmpeg in the future

Signed-off-by: crueter crueter@crueter.xyz

Replaces bundled SDL2 with my SDL2 CI, and updates external SDL2 Additionally, reduces all that boilerplate with a common AddCIPackage in CPMUtil.cmake, currently used by OpenSSL and SDL2. To be used with ffmpeg in the future Signed-off-by: crueter <crueter@crueter.xyz>
Shinmegumi approved these changes 2025-08-20 20:18:03 +02:00
Dismissed
Shinmegumi left a comment
Owner
Copy link

Still needs some testing, but approved for whenever crueter is ready to push it.

Still needs some testing, but approved for whenever crueter is ready to push it.
crueter dismissed Shinmegumi's review 2025-08-20 20:38:00 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie approved these changes 2025-08-21 20:02:57 +02:00
Dismissed
crueter dismissed Lizzie's review 2025-08-21 20:03:41 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

crueter commented 2025-08-21 23:04:31 +02:00
Author
Owner
Copy link

basically done pending solaris and freebsd tests, TODO for later is to add ability to download externals sdl2 alongside bundled (separate option maybe???)

basically done pending solaris and freebsd tests, TODO for later is to add ability to download externals sdl2 alongside bundled (separate option maybe???)
Shinmegumi approved these changes 2025-08-23 19:14:55 +02:00
Shinmegumi force-pushed feature/sdl2-ci from bf6a72a96d to 700842ca01 2025-08-23 19:42:25 +02:00 Compare
Shinmegumi merged commit 94bcd64153 into master 2025-08-23 19:42:50 +02:00
Shinmegumi deleted branch feature/sdl2-ci 2025-08-23 19:42:50 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#284
No description provided.
Delete branch "feature/sdl2-ci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?