eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 63 Projects 1 Releases Wiki Activity Actions

[meta] fix building with clang 21.1.4 #2839

Merged
crueter merged 2 commits from DraVee/eden:clang_21 into master 2025-10-27 00:37:25 +01:00
Conversation 2 Commits 2 Files changed 3 +9 -3
DraVee commented 2025-10-26 03:50:36 +01:00
Member
Copy link

Signed-off-by: Caio Oliveira caiooliveirafarias0@gmail.com

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
[meta] fix building with clang 21.1.4
Some checks failed
eden-license / license-header (pull_request) Failing after 30s
Details
GitHub Actions [CI] Build failed
Details
db3a3a2194 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
crueter force-pushed clang_21 from db3a3a2194
Some checks failed
eden-license / license-header (pull_request) Failing after 30s
Details
GitHub Actions [CI] Build failed
Details
to d22982bb10
Some checks failed
build.yml / [meta] fix building with clang 21.1.4 (pull_request) Failing after 0s
Details
trigger_release.yml / [meta] fix building with clang 21.1.4 (pull_request) Failing after 0s
Details
eden-license / license-header (pull_request) Failing after 32s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-26 19:23:43 +01:00 Compare
DraVee force-pushed clang_21 from d22982bb10
Some checks failed
build.yml / [meta] fix building with clang 21.1.4 (pull_request) Failing after 0s
Details
trigger_release.yml / [meta] fix building with clang 21.1.4 (pull_request) Failing after 0s
Details
eden-license / license-header (pull_request) Failing after 32s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 4648925716
Some checks failed
eden-license / license-header (pull_request) Failing after 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-26 21:24:42 +01:00 Compare
license: fix headers
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2b4badac6e
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
cmake: WIP [DO NOT MERGE]
Some checks reported errors
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build cancelled
Details
4639a3582d
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
DraVee changed title from [meta] fix building with clang 21.1.4 to WIP: [meta] fix building with clang 21.1.4 2025-10-26 22:40:35 +01:00
crueter requested changes 2025-10-26 22:40:57 +01:00
CMakeLists.txt Outdated
@ -188,3 +188,3 @@
set(EXT_DEFAULT OFF)
if (MSVC OR ANDROID)
if (MINGW OR MSVC OR ANDROID)
crueter commented 2025-10-26 22:40:54 +01:00
Owner
Copy link

????

????
DraVee commented 2025-10-26 22:41:46 +01:00
Author
Member
Copy link

Testing

Testing
DraVee commented 2025-10-26 22:43:02 +01:00
Author
Member
Copy link

@crueter wrote in #2839 (comment):

????

` CMake Error at CMakeModules/CPMUtil.cmake:626 (find_package):
By not providing "Findsirit.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "sirit", but
CMake did not find one.

Could not find a package configuration file provided by "sirit" with any of
the following names:

siritConfig.cmake
sirit-config.cmake`
@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/2839#issuecomment-8282: > ???? ` CMake Error at CMakeModules/CPMUtil.cmake:626 (find_package): By not providing "Findsirit.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "sirit", but CMake did not find one. Could not find a package configuration file provided by "sirit" with any of the following names: siritConfig.cmake sirit-config.cmake`
crueter commented 2025-10-26 22:44:07 +01:00
Owner
Copy link

MinGW doesn't package sirit so that's expected--it's pulled in by CPM anyways, CPMUTIL_FORCE_SYSTEM isn't gonna work with distros that don't package everything

MinGW doesn't package sirit so that's expected--it's pulled in by CPM anyways, CPMUTIL_FORCE_SYSTEM isn't gonna work with distros that don't package everything
DraVee marked this conversation as resolved
DraVee force-pushed clang_21 from 4639a3582d
Some checks reported errors
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build cancelled
Details
to 2b4badac6e
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-26 22:48:20 +01:00 Compare
DraVee changed title from WIP: [meta] fix building with clang 21.1.4 to [meta] fix building with clang 21.1.4 2025-10-27 00:28:10 +01:00
DraVee requested review from crueter 2025-10-27 00:28:10 +01:00
DraVee commented 2025-10-27 00:29:25 +01:00
Author
Member
Copy link

Ready to merge (gave up on trying to configure mingw on CI)

Ready to merge (gave up on trying to configure mingw on CI)
crueter merged commit 0be29d2947 into master 2025-10-27 00:37:25 +01:00
crueter deleted branch clang_21 2025-10-27 00:37:25 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
MaranBr
Lizzie
CamilleLaVey
Maufeat
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2839
No description provided.