eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 62 Projects 1 Releases Wiki Activity Actions

[cmake] MinGW builds; fix line endings; fix weird multiplayer lobby behavior #2835

Merged
crueter merged 5 commits from fix/mingw into master 2025-10-26 17:28:15 +01:00
Conversation 7 Commits 5 Files changed 12 +269 -254
crueter commented 2025-10-25 05:56:49 +02:00
Owner
Copy link

MinGW builds perform pretty dramatically better than MSVC in my (brief) testing, getting 40% better FPS on my KVM than MSVC. How this will translate to the real world, who knows, but this is a really good target to have.

TODO: Add this to CI, potentially replace clang-cl

Signed-off-by: crueter crueter@eden-emu.dev

MinGW builds perform pretty dramatically better than MSVC in my (brief) testing, getting 40% better FPS on my KVM than MSVC. How this will translate to the real world, who knows, but this is a really good target to have. TODO: Add this to CI, potentially replace clang-cl Signed-off-by: crueter <crueter@eden-emu.dev>
[cmake] MinGW builds; fix line endings
Some checks failed
eden-license / license-header (pull_request) Failing after 32s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
91e0d5b6a8
 
Still need to test if this actually works, but it builds now

Signed-off-by: crueter <crueter@eden-emu.dev>
fix headers, msys2 dep docs
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
4a38abf3e3
 
Signed-off-by: crueter <crueter@eden-emu.dev>
fix msvc httplib
Some checks reported errors
eden-license / license-header (pull_request) Failing after 29s
Details
GitHub Actions [CI] Build cancelled
Details
1b5899aa9e 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter changed title from [cmake] MinGW builds; fix line endings to [cmake] MinGW builds; fix line endings; fix weird multiplayer lobby behavior 2025-10-25 09:02:20 +02:00
Fix license headers
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
8ae0ec35bd
DraVee reviewed 2025-10-25 15:42:17 +02:00
.ci/windows/install-msvc.ps1 Outdated
@ -1,60 +1,60 @@
# SPDX-FileCopyrightText: 2025 Eden Emulator Project
DraVee commented 2025-10-25 15:42:17 +02:00
Member
Copy link

Nuke this file, should be moved outside too

Nuke this file, should be moved outside too
crueter marked this conversation as resolved
DraVee reviewed 2025-10-25 15:42:52 +02:00
CMakeModules/MSVCCache.cmake Outdated
@ -1,15 +1,18 @@
# SPDX-FileCopyrightText: 2022 yuzu Emulator Project
DraVee commented 2025-10-25 15:42:52 +02:00
Member
Copy link

We are using ccache detection direct on main CMakeLists, could be nuked too

We are using ccache detection direct on main CMakeLists, could be nuked too
crueter marked this conversation as resolved
DraVee reviewed 2025-10-26 02:34:06 +02:00
docs/Deps.md
@ -209,1 +210,3 @@
* Add MinGW binaries to the PATH:
* Download and install all dependencies:
```
BASE="git make autoconf libtool automake-wrapper"
DraVee commented 2025-10-26 02:34:02 +02:00
Member
Copy link

Add jq too, need by install.sh

Add jq too, need by install.sh
crueter commented 2025-10-26 02:36:11 +02:00
Author
Owner
Copy link

https://git.crueter.xyz/scripts/windev/src/branch/master/install.sh#L25

https://git.crueter.xyz/scripts/windev/src/branch/master/install.sh#L25
DraVee commented 2025-10-26 02:44:54 +02:00
Member
Copy link

But:
https://git.crueter.xyz/scripts/windev/src/branch/master/install.sh#L19

But: https://git.crueter.xyz/scripts/windev/src/branch/master/install.sh#L19
crueter commented 2025-10-26 02:47:43 +02:00
Author
Owner
Copy link

Those scripts are designed only to be used on a clean system, not one with MSYS2 already installed (sans the package options)

Those scripts are designed only to be used on a clean system, not one with MSYS2 already installed (sans the package options)
👍 1
crueter commented 2025-10-26 02:54:37 +02:00
Author
Owner
Copy link

Actually, it couldn't hurt to have for the cpm scripts

Actually, it couldn't hurt to have for the cpm scripts
crueter marked this conversation as resolved
remove stale stuff, add jq/patch
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
516383188e
 
Signed-off-by: crueter <crueter@eden-emu.dev>
DraVee commented 2025-10-26 02:00:20 +01:00
Member
Copy link

As cleanup we need to see if are usefull too

MinGWClangCross.cmake, MinGWCross.cmake, MSVCCache.cmake

Tested, they are useless (we can simple use -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++)

As cleanup we need to see if are usefull too `MinGWClangCross.cmake`, `MinGWCross.cmake`, `MSVCCache.cmake` Tested, they are useless (we can simple use `-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++`)
crueter commented 2025-10-26 02:13:23 +01:00
Author
Owner
Copy link

Even better, on Gentoo x86_64-w64-mingw32-cmake -S . -B build handles everything for us

Even better, on Gentoo `x86_64-w64-mingw32-cmake -S . -B build` handles everything for us
MaranBr approved these changes 2025-10-26 14:56:27 +01:00
DraVee commented 2025-10-26 15:12:40 +01:00
Member
Copy link

Needs #2839

Needs #2839
crueter merged commit a0769ad835 into master 2025-10-26 17:28:15 +01:00
crueter deleted branch fix/mingw 2025-10-26 17:28:16 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
Lizzie
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2835
No description provided.