[logging, debugger] remove unescesary logic and only query USER env variable once #2800

Merged

crueter merged 4 commits from backend-improv1 into master 2025-10-27 20:55:02 +01:00

Conversation 1 Commits 4 Files changed 5 +267 -434

Lizzie commented 2025-10-20 21:21:37 +02:00

Member

Copy link

• censoring an username would lead to the variable being queried everytime something is written, just store it on a static
• dont use a map<> for something that can be done in a switch statment (and that the compiler will optimise for free!!!)
  Signed-off-by: lizzie lizzie@eden-emu.dev

- censoring an username would lead to the variable being queried everytime something is written, just store it on a static - dont use a map<> for something that can be done in a switch statment (and that the compiler will optimise for free!!!) Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie requested reviews from MaranBr, CamilleLaVey, Maufeat, crueter, MrPurple666 2025-10-20 21:21:37 +02:00

Lizzie force-pushed backend-improv1 from 02eec2a7d8 to 87c0994a0d 2025-10-21 20:31:58 +02:00 Compare

Lizzie force-pushed backend-improv1 from 87c0994a0d to f586f754ba 2025-10-23 08:28:12 +02:00 Compare

crueter added this to the 0.0.4 milestone 2025-10-27 08:00:39 +01:00

Lizzie force-pushed backend-improv1 from f586f754ba to 908718878c 2025-10-27 19:51:33 +01:00 Compare

Lizzie added 1 commit 2025-10-27 20:05:05 +01:00

fix? ... a84277184d

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie added 1 commit 2025-10-27 20:06:32 +01:00

fx ... d3dc51529f

Signed-off-by: lizzie <lizzie@eden-emu.dev>

crueter approved these changes 2025-10-27 20:50:26 +01:00

crueter merged commit dd9cae4ebc into master 2025-10-27 20:55:02 +01:00

crueter deleted branch backend-improv1 2025-10-27 20:55:02 +01:00

crueter referenced this pull request from a commit 2025-10-27 20:55:02 +01:00

[logging, debugger] remove unescesary logic and only query USER env variable once (#2800)

Sign in to join this conversation.

Reviewers

No reviewers

MaranBr

CamilleLaVey

Maufeat

MrPurple666

crueter

Labels

Clear labels   

android

Specific to android platform

  

audio

  

bug

Something is not working

  

ci

For changes to the ci/building

  

cmake

  

confirmed

Used when testers confirm a bug is reported and it is reproducable.

  

core

For core changes to the emulator

  

desktop

Specific to desktop PCs, handhelds, etc.

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Frontend changes

  

fw

Changes related to firmware

  

git

For enhancements or changes regarding git.

  

graphics

  

loader

For changes to any of the loader implementations

  

nv gpu

For use with changes that involve the emulator GPU and any services.

  

ui

  

vulkan

Used on anything Vulkan-related

No labels

android

audio

bug

ci

cmake

confirmed

core

desktop

duplicate

enhancement

frontend

fw

git

graphics

loader

nv gpu

ui

vulkan

Milestone

Clear milestone

No items

No milestone

0.0.4

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

eden-emu/eden!2800

No description provided.