eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 62 Projects 1 Releases Wiki Activity Actions

[desktop] Fix misaligned output device #2786

Merged
MaranBr merged 2 commits from fix/audio into master 2025-10-20 04:08:40 +02:00
Conversation 7 Commits 2 Files changed 4 +17 -4
crueter commented 2025-10-19 19:41:30 +02:00
Owner
Copy link

Builder::BuildWidget previously relied on Qt to handle layout stretching
by implicitly setting each widget to have a stretch of 0. This is very
bad behavior, so to fix this we must set a stretch of 1 on each widget
that's added by the builder

furthermore, default and default_dark did not properly define a min-width or min-height for QComboBox. This caused the platform theme to take over sizing which is NOT GOOD and should basically be avoided always

Signed-off-by: crueter crueter@eden-emu.dev

Builder::BuildWidget previously relied on Qt to handle layout stretching by implicitly setting each widget to have a stretch of 0. This is very bad behavior, so to fix this we must set a stretch of 1 on each widget that's added by the builder furthermore, default and default_dark did not properly define a min-width or min-height for QComboBox. This caused the platform theme to take over sizing which is NOT GOOD and should basically be avoided always Signed-off-by: crueter <crueter@eden-emu.dev>
[desktop] Fix misaligned output device
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build succeeded
Details
c25114d29f
 
Builder::BuildWidget previously relied on Qt to handle layout stretching
by implicitly setting each widget to have a stretch of 0. This is very
bad behavior, so to fix this we must set a stretch of 1 on each widget
that's added by the builder

Signed-off-by: crueter <crueter@eden-emu.dev>
MaranBr approved these changes 2025-10-19 20:09:20 +02:00
Dismissed
MaranBr commented 2025-10-19 23:44:51 +02:00
Member
Copy link

It's even more misaligned than before

It's even more misaligned than before
crueter commented 2025-10-19 23:48:22 +02:00
Author
Owner
Copy link

@MaranBr wrote in #2786 (comment):

It's even more misaligned than before

screenshot

@MaranBr wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/2786#issuecomment-7430: > It's even more misaligned than before screenshot
MaranBr commented 2025-10-19 23:54:20 +02:00
Member
Copy link
No description provided.
SMW.png
204 KiB
SMW.png
crueter commented 2025-10-20 03:41:23 +02:00
Author
Owner
Copy link

This is caused by default_dark and default not defining anything for QComboBox (most importantly min-width)

image

The only question is whether or not it may be preferable to keep this, because otherwise things get cut off

image

This is caused by default_dark and default not defining anything for QComboBox (most importantly min-width) ![image](/attachments/7215756a-d5ef-4ecf-8950-46e478e77e87) The only question is whether or not it may be preferable to keep this, because otherwise things get cut off ![image](/attachments/03e27e4e-f295-408b-91dc-fb088e19b651)
image.png
27 KiB
image.png
20 KiB
define min sizes, padding for QComboBox
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build succeeded
Details
65fe14f559
 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter dismissed MaranBr's review 2025-10-20 03:41:27 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

MaranBr approved these changes 2025-10-20 04:07:33 +02:00
MaranBr scheduled this pull request to auto merge when all checks succeed 2025-10-20 04:07:42 +02:00
MaranBr merged commit 54d6283ac3 into master 2025-10-20 04:08:40 +02:00
MaranBr deleted branch fix/audio 2025-10-20 04:08:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
Lizzie
Maufeat
MaranBr
CamilleLaVey
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2786
No description provided.