eden-emu/eden
24
3
Fork 18
Code Issues 88 Pull requests 73 Projects 1 Releases 7 Wiki Activity Actions

[compat] Solaris build fixes for openssl, catch2; NetBSD build fixes #2752

Merged
MaranBr merged 23 commits from fix-solaris-stuff-1213 into master 2025-10-17 22:12:59 +02:00
Conversation 8 Commits 23 Files changed 22 +247 -100
Lizzie commented 2025-10-16 09:53:26 +02:00
Member
Copy link

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>
Shinmegumi approved these changes 2025-10-16 14:25:53 +02:00
Dismissed
MaranBr approved these changes 2025-10-16 17:12:31 +02:00
Dismissed
crueter requested changes 2025-10-16 17:54:35 +02:00
Dismissed
CMakeLists.txt Outdated
@ -261,3 +261,3 @@
option(ENABLE_OPENSSL "Enable OpenSSL backend for ISslConnection" ${DEFAULT_ENABLE_OPENSSL})
if (ENABLE_OPENSSL)
cmake_dependent_option(YUZU_USE_BUNDLED_OPENSSL "Download bundled OpenSSL build" "${MSVC}" "NOT ANDROID" ON)
cmake_dependent_option(YUZU_USE_BUNDLED_OPENSSL "Download bundled OpenSSL build" ON "MSVC OR PLATFORM_SUN" OFF)
crueter commented 2025-10-16 17:54:25 +02:00
Owner
Copy link

This isn't how CMakeDependentOption works. If the latter condition is true then the option is added, otherwise it's forcefully set to the former

This isn't how CMakeDependentOption works. If the latter condition is true then the option is added, otherwise it's forcefully set to the former
src/qt_common/util/content.cpp Outdated
@ -505,3 +507,3 @@
&QtProgressDialog::setValue,
static_cast<int>((processed_size * 100) / total_size));
#endif
crueter commented 2025-10-16 17:54:33 +02:00
Owner
Copy link

What breaks here?

What breaks here?
Lizzie commented 2025-10-16 20:00:51 +02:00
Author
Member
Copy link

last arg expected to be (void*), but was int

last arg expected to be (void*), but was int
crueter commented 2025-10-16 21:04:35 +02:00
Owner
Copy link

Q_ARG(int, static_cast<int>((processed_size * 100) / total_size))

qt 4 docs

 QMetaObject::invokeMethod(obj, "compute", Qt::DirectConnection,
                           Q_RETURN_ARG(QString, retVal),
                           Q_ARG(QString, "sqrt"),
                           Q_ARG(int, 42),
                           Q_ARG(double, 9.7));
`Q_ARG(int, static_cast<int>((processed_size * 100) / total_size))` qt 4 docs ```cpp QMetaObject::invokeMethod(obj, "compute", Qt::DirectConnection, Q_RETURN_ARG(QString, retVal), Q_ARG(QString, "sqrt"), Q_ARG(int, 42), Q_ARG(double, 9.7)); ```
Lizzie dismissed Shinmegumi's review 2025-10-16 20:09:28 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie dismissed MaranBr's review 2025-10-16 20:09:28 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

crueter reviewed 2025-10-16 21:04:56 +02:00
CMakeLists.txt Outdated
@ -264,0 +264,4 @@
if (MSVC OR PLATFORM_SUN)
set(DEFAULT_YUZU_USE_BUNDLED_OPENSSL ON)
endif()
option(YUZU_USE_BUNDLED_OPENSSL "Download bundled OpenSSL build" ${DEFAULT_YUZU_USE_BUNDLED_OPENSSL})
crueter commented 2025-10-16 21:04:54 +02:00
Owner
Copy link

What's broken with OpenSSL on solaris

What's broken with OpenSSL on solaris
Lizzie commented 2025-10-16 21:35:21 +02:00
Author
Member
Copy link

version too old

version too old
crueter commented 2025-10-16 22:08:48 +02:00
Owner
Copy link

Oh nvm I misread

Oh nvm I misread
crueter marked this conversation as resolved
Lizzie changed title from [compat] solaris build fixes for openssl, catch2 to [compat] Solaris build fixes for openssl, catch2; NetBSD build fixes 2025-10-16 21:34:59 +02:00
DraVee commented 2025-10-16 22:03:32 +02:00
Member
Copy link

Android still falling:
C/C++: CMake Error at /usr/local/lib/android/sdk/cmake/3.22.1/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message): C/C++: Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the C/C++: system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY C/C++: OPENSSL_INCLUDE_DIR) (Required is at least version "1.1.1")

Android still falling: `C/C++: CMake Error at /usr/local/lib/android/sdk/cmake/3.22.1/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message): C/C++: Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the C/C++: system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY C/C++: OPENSSL_INCLUDE_DIR) (Required is at least version "1.1.1")`
crueter commented 2025-10-16 22:09:11 +02:00
Owner
Copy link

Oh yeah, make it EXT_DEFAULT OR PLATFORM_SUN

Oh yeah, make it EXT_DEFAULT OR PLATFORM_SUN
Lizzie force-pushed fix-solaris-stuff-1213 from 6ffb71340f
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
to 9425373dbc
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
2025-10-17 02:29:16 +02:00 Compare
Lizzie force-pushed fix-solaris-stuff-1213 from e16df53f9d
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
to 0e3233514e
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
2025-10-17 09:48:09 +02:00 Compare
fix wattOS
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
87526257f1
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
fix
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
9d822053d9
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
fix typo once again
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
3ac226a5d0
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
crueter approved these changes 2025-10-17 22:12:10 +02:00
crueter added this to the 0.0.4 (real) milestone 2025-10-17 22:12:19 +02:00
MaranBr approved these changes 2025-10-17 22:12:52 +02:00
MaranBr merged commit 3e8fe622a7 into master 2025-10-17 22:12:59 +02:00
MaranBr deleted branch fix-solaris-stuff-1213 2025-10-17 22:13:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
crueter
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
0.0.4 (real)
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2752
No description provided.