From ca0d5326c389e4595f789937863cdeb0d3d441a2 Mon Sep 17 00:00:00 2001 From: Ribbit Date: Thu, 9 Oct 2025 21:33:05 -0700 Subject: [PATCH 1/2] another attempt --- src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index 9cdbe5611b..289ef168d0 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp @@ -318,6 +318,7 @@ PipelineCache::PipelineCache(Tegra::MaxwellDeviceMemoryManager& device_memory_, serialization_thread(1, "VkPipelineSerialization") { const auto& float_control{device.FloatControlProperties()}; const VkDriverId driver_id{device.GetDriverID()}; + const bool is_stock_qualcomm_driver{driver_id == VK_DRIVER_ID_QUALCOMM_PROPRIETARY}; profile = Shader::Profile{ .supported_spirv = device.SupportedSpirvVersion(), .unified_descriptor_binding = true, @@ -331,13 +332,16 @@ PipelineCache::PipelineCache(Tegra::MaxwellDeviceMemoryManager& device_memory_, float_control.denormBehaviorIndependence == VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_ALL, .support_separate_rounding_mode = float_control.roundingModeIndependence == VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_ALL, - .support_fp16_denorm_preserve = float_control.shaderDenormPreserveFloat16 != VK_FALSE, + .support_fp16_denorm_preserve = + is_stock_qualcomm_driver && float_control.shaderDenormPreserveFloat16 != VK_FALSE, .support_fp32_denorm_preserve = float_control.shaderDenormPreserveFloat32 != VK_FALSE, .support_fp16_denorm_flush = float_control.shaderDenormFlushToZeroFloat16 != VK_FALSE, .support_fp32_denorm_flush = float_control.shaderDenormFlushToZeroFloat32 != VK_FALSE, .support_fp16_signed_zero_nan_preserve = + is_stock_qualcomm_driver && float_control.shaderSignedZeroInfNanPreserveFloat16 != VK_FALSE, .support_fp32_signed_zero_nan_preserve = + is_stock_qualcomm_driver && float_control.shaderSignedZeroInfNanPreserveFloat32 != VK_FALSE, .support_fp64_signed_zero_nan_preserve = float_control.shaderSignedZeroInfNanPreserveFloat64 != VK_FALSE, -- 2.39.5 From f8cdec864e00f4ba23bfe0b254129082d51e5250 Mon Sep 17 00:00:00 2001 From: Ribbit Date: Thu, 9 Oct 2025 22:07:56 -0700 Subject: [PATCH 2/2] another one --- .../renderer_vulkan/vk_pipeline_cache.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index 289ef168d0..701fd2bda2 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp @@ -333,18 +333,18 @@ PipelineCache::PipelineCache(Tegra::MaxwellDeviceMemoryManager& device_memory_, .support_separate_rounding_mode = float_control.roundingModeIndependence == VK_SHADER_FLOAT_CONTROLS_INDEPENDENCE_ALL, .support_fp16_denorm_preserve = - is_stock_qualcomm_driver && float_control.shaderDenormPreserveFloat16 != VK_FALSE, - .support_fp32_denorm_preserve = float_control.shaderDenormPreserveFloat32 != VK_FALSE, - .support_fp16_denorm_flush = float_control.shaderDenormFlushToZeroFloat16 != VK_FALSE, - .support_fp32_denorm_flush = float_control.shaderDenormFlushToZeroFloat32 != VK_FALSE, + is_stock_qualcomm_driver && float_control.shaderDenormPreserveFloat16 == VK_TRUE, + .support_fp32_denorm_preserve = float_control.shaderDenormPreserveFloat32 == VK_TRUE, + .support_fp16_denorm_flush = float_control.shaderDenormFlushToZeroFloat16 == VK_TRUE, + .support_fp32_denorm_flush = float_control.shaderDenormFlushToZeroFloat32 == VK_TRUE, .support_fp16_signed_zero_nan_preserve = is_stock_qualcomm_driver && - float_control.shaderSignedZeroInfNanPreserveFloat16 != VK_FALSE, + float_control.shaderSignedZeroInfNanPreserveFloat16 == VK_TRUE, .support_fp32_signed_zero_nan_preserve = is_stock_qualcomm_driver && - float_control.shaderSignedZeroInfNanPreserveFloat32 != VK_FALSE, + float_control.shaderSignedZeroInfNanPreserveFloat32 == VK_TRUE, .support_fp64_signed_zero_nan_preserve = - float_control.shaderSignedZeroInfNanPreserveFloat64 != VK_FALSE, + float_control.shaderSignedZeroInfNanPreserveFloat64 == VK_TRUE, .support_explicit_workgroup_layout = device.IsKhrWorkgroupMemoryExplicitLayoutSupported(), .support_vote = device.IsSubgroupFeatureSupported(VK_SUBGROUP_FEATURE_VOTE_BIT), .support_viewport_index_layer_non_geometry = -- 2.39.5