eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

WIP: [frontend, android] Move update_checker to frontend_common and add Android support #2687

Draft
inix wants to merge 4 commits from inix/eden:update-checker-android into master
pull from: inix/eden:update-checker-android
merge into: eden-emu:master
Conversation 3 Commits 4 Files changed 21 +237 -35
inix commented 2025-10-06 17:25:34 +02:00
Member
Copy link

I still have to add a setting to disable the auto update checking on a later PR, firstly lets make sure i didn't accidentally break anything with CMAKE. or QT.

I still have to add a setting to disable the auto update checking on a later PR, firstly lets make sure i didn't accidentally break anything with CMAKE. or QT.
inix added 3 commits 2025-10-06 17:25:35 +02:00
[kotlin] Don't check for updates if ENABLE_UPDARE_CHECKERE is OFF
Some checks failed
eden-license / license-header (pull_request) Failing after 31s
Details
67c3197ee5
requested reviews from crueter, CamilleLaVey, Maufeat, MrPurple666, MaranBr, Lizzie 2025-10-06 17:25:35 +02:00
inix added 1 commit 2025-10-06 17:34:51 +02:00
license header
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
a34d1aeaa4
DraVee requested changes 2025-10-06 19:04:34 +02:00
CMakeLists.txt
@ -570,0 +575,4 @@
message(STATUS "DEVEL=$ENV{DEVEL}: Disabling updates checker for development builds")
set(ENABLE_UPDATE_CHECKER OFF)
endif()
endif()
DraVee commented 2025-10-06 19:04:30 +02:00
Member
Copy link

I don't think this a good way to check for DEVEL, as we shouldn't rely on system environment variables (or at least I think we shouldn't

I don't think this a good way to check for DEVEL, as we shouldn't rely on system environment variables (or at least I think we shouldn't
crueter commented 2025-10-07 02:27:58 +02:00
Owner
Copy link

Yeah, DEVEL should be CI-local, not CMake-based

Yeah, `DEVEL` should be CI-local, not CMake-based
src/frontend_common/CMakeLists.txt
@ -1,5 +1,5 @@
# SPDX-FileCopyrightText: 2023 yuzu Emulator Project
# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
# SPDX-License-Identifier: GPL-3.0-or-later
DraVee commented 2025-10-06 19:02:32 +02:00
Member
Copy link

Dont remove old copyright header

Dont remove old copyright header
CamilleLaVey approved these changes 2025-10-07 02:24:24 +02:00
Lizzie approved these changes 2025-10-07 04:12:13 +02:00
crueter changed title from [frontend, android] Move update_checker to frontend_common and add Android support to WIP: [frontend, android] Move update_checker to frontend_common and add Android support 2025-10-07 04:19:35 +02:00
crueter added this to the 0.0.4 (real) milestone 2025-10-10 02:45:41 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u update-checker-android:inix-update-checker-android
git checkout inix-update-checker-android
Sign in to join this conversation.
Reviewers
No reviewers
crueter
Maufeat
MrPurple666
MaranBr
DraVee
CamilleLaVey
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
0.0.4 (real)
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2687
No description provided.
Delete branch "inix/eden:update-checker-android"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?