eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[windows] Use condvar wait to reduce sched contention #2686

Closed
Lizzie wants to merge 1 commit from win-use-condvar-wait into master
pull from: win-use-condvar-wait
merge into: eden-emu:master
Conversation 2 Commits 1 Files changed 1 +1 -21
Lizzie commented 2025-10-06 11:12:16 +02:00
Member
Copy link

This uses native conditional_var.wait() instead of doing a micromanagement of sleep and stuff. Should change scheduling policies to reduce thread contention. Windows particularly doesn't like small quanta anyways. This may also fix Windows ARM.
Keywords: May, should

Signed-off-by: lizzie lizzie@eden-emu.dev

This uses native conditional_var.wait() instead of doing a micromanagement of sleep and stuff. *Should* change scheduling policies to reduce thread contention. Windows particularly doesn't like small quanta anyways. This may also fix Windows ARM. Keywords: May, should Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-10-06 11:12:16 +02:00
[windows] Use condvar wait to reduce sched contention
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
ee4d944340 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested reviews from CamilleLaVey, Maufeat, crueter, MrPurple666, MaranBr 2025-10-06 11:12:16 +02:00
Shinmegumi commented 2025-10-06 18:51:37 +02:00
Owner
Copy link

Need to test on Windows, but @Lizzie, looks like this is having an adverse effect on Steam Deck. It is causing frame dips in TOTK out of random playthroughs. Potentially a thread is going to sleep or waiting and never gets a signal. You might be able to direct John on what to look at to see if we can catch it.

Need to test on Windows, but @Lizzie, looks like this is having an adverse effect on Steam Deck. It is causing frame dips in TOTK out of random playthroughs. Potentially a thread is going to sleep or waiting and never gets a signal. You might be able to direct John on what to look at to see if we can catch it.
Lizzie commented 2025-10-07 04:04:30 +02:00
Author
Member
Copy link

Reduced performance on Windows considerably on various games; STL implementation for condvar is not appropriate, perhaps busy wait?

Reduced performance on Windows considerably on various games; STL implementation for condvar is not appropriate, perhaps busy wait?
Lizzie closed this pull request 2025-10-07 04:04:30 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
crueter
MrPurple666
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2686
No description provided.
Delete branch "win-use-condvar-wait"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?