eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk] Fix Vulkan Upload & Present Barriers for Spec Compliance #2681

Merged
Shinmegumi merged 1 commit from Ribbit/ribbitvulkanadditions:speccompliance into master 2025-10-06 17:39:33 +02:00
Conversation 2 Commits 1 Files changed 3 +4 -4
Ribbit commented 2025-10-06 03:20:47 +02:00
Contributor
Copy link

The barrier before the CPU-upload copy was using VK_PIPELINE_STAGE_HOST_BIT. Validation rules only allow HOST as the source stage if you’re also specifying host-side access flags; inside a command buffer the GPU isn’t executing “host work,” so pairing that stage with the usual image layout transition is technically invalid.

Switching the source stage to VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT keeps the ordering guarantee we need and satisfies the spec, while the actual host visibility is still handled correctly by the preceding vmaFlushAllocation.

The barrier before the CPU-upload copy was using VK_PIPELINE_STAGE_HOST_BIT. Validation rules only allow HOST as the source stage if you’re also specifying host-side access flags; inside a command buffer the GPU isn’t executing “host work,” so pairing that stage with the usual image layout transition is technically invalid. Switching the source stage to VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT keeps the ordering guarantee we need and satisfies the spec, while the actual host visibility is still handled correctly by the preceding vmaFlushAllocation.
Ribbit added 1 commit 2025-10-06 03:20:48 +02:00
[vk] Fix Vulkan Upload & Present Barriers for Spec Compliance
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
a9b02e9eb1
Ribbit force-pushed speccompliance from a9b02e9eb1 to 82f8ef2fe8 2025-10-06 03:20:57 +02:00 Compare
Ribbit changed title from WIP: [vk] Fix Vulkan Upload & Present Barriers for Spec Compliance to [vk] Fix Vulkan Upload & Present Barriers for Spec Compliance 2025-10-06 05:42:40 +02:00
requested reviews from Maufeat, crueter, MaranBr, Lizzie, CamilleLaVey 2025-10-06 05:42:40 +02:00
Ribbit changed title from [vk] Fix Vulkan Upload & Present Barriers for Spec Compliance to WIP: [vk] Fix Vulkan Upload & Present Barriers for Spec Compliance 2025-10-06 05:42:54 +02:00
Ribbit changed title from WIP: [vk] Fix Vulkan Upload & Present Barriers for Spec Compliance to [vk] Fix Vulkan Upload & Present Barriers for Spec Compliance 2025-10-06 05:42:56 +02:00
requested review from wildcard 2025-10-06 05:42:57 +02:00
MaranBr approved these changes 2025-10-06 06:00:14 +02:00
Shinmegumi approved these changes 2025-10-06 17:02:37 +02:00
Shinmegumi left a comment
Owner
Copy link

Testers report that there are no issues and this change raises lows creating less stutter and a smoother experience.

Testers report that there are no issues and this change raises lows creating less stutter and a smoother experience.
Shinmegumi merged commit 5d4cfe195b into master 2025-10-06 17:39:33 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
crueter
Lizzie
CamilleLaVey
wildcard
MaranBr
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2681
No description provided.
Delete branch "Ribbit/ribbitvulkanadditions:speccompliance"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?