eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk] Unify RAII in Vulkan #2679

Merged
MaranBr merged 2 commits from Ribbit/ribbitvulkanadditions:raiichanges into master 2025-10-08 04:01:25 +02:00
Conversation 6 Commits 2 Files changed 35 +42 -353
Ribbit commented 2025-10-06 02:35:05 +02:00
Contributor
Copy link

This PR consolidates Vulkan RAII on video_core/vulkan_common/vulkan_wrapper.h’s vk::Handle and remove the unused duplicate src/video_core/vulkan_common/vulkan_raii.h, reducing confusion and maintenance. Swapchain now uses RAII‑managed per‑image semaphores and clears them in Destroy(), providing correct present synchronization and automatic cleanup. Expected result: simpler lifetimes, fewer leak risks, and more stable presentation with negligible overhead.

This PR consolidates Vulkan RAII on video_core/vulkan_common/vulkan_wrapper.h’s vk::Handle and remove the unused duplicate src/video_core/vulkan_common/vulkan_raii.h, reducing confusion and maintenance. Swapchain now uses RAII‑managed per‑image semaphores and clears them in Destroy(), providing correct present synchronization and automatic cleanup. Expected result: simpler lifetimes, fewer leak risks, and more stable presentation with negligible overhead.
Ribbit added 1 commit 2025-10-06 02:35:06 +02:00
[vk] Unify RAII in Vulkan
Some checks failed
eden-license / license-header (pull_request) Failing after 22s
Details
4916d70d7b
Ribbit added 1 commit 2025-10-06 05:07:32 +02:00
[vk] Descriptor pools: per-set free + RAII release; add ResourcePool::Drain
Some checks failed
eden-license / license-header (pull_request) Failing after 23s
Details
8200e397ef
Ribbit force-pushed raiichanges from 8200e397ef to a0380aa756 2025-10-06 05:07:55 +02:00 Compare
Ribbit added 4 commits 2025-10-06 05:23:33 +02:00
[vk] Unify RAII in Vulkan
Some checks failed
eden-license / license-header (pull_request) Failing after 22s
Details
4916d70d7b
[vk] Descriptor pools: per-set free + RAII release; add ResourcePool::Drain
Some checks failed
eden-license / license-header (pull_request) Failing after 23s
Details
8200e397ef 
This reverts commit 8200e397ef.
Merge branch 'raiichanges' of https://git.eden-emu.dev/Ribbit/ribbitvulkanadditions into raiichanges
Some checks failed
eden-license / license-header (pull_request) Failing after 23s
Details
52cbf4507b
Ribbit force-pushed raiichanges from 52cbf4507b to 2700929161 2025-10-06 05:30:09 +02:00 Compare
Ribbit commented 2025-10-07 01:54:22 +02:00
Author
Contributor
Copy link

Back to the workshop this PR goes.

Back to the workshop this PR goes.
Ribbit force-pushed raiichanges from 2700929161 to c404d3e0bd 2025-10-07 02:44:18 +02:00 Compare
MaranBr changed title from WIP: [vk] Unify RAII in Vulkan to [vk] Unify RAII in Vulkan 2025-10-07 02:45:33 +02:00
requested reviews from Maufeat, crueter, MrPurple666, MaranBr, Lizzie, CamilleLaVey 2025-10-07 02:45:33 +02:00
CamilleLaVey approved these changes 2025-10-07 15:40:57 +02:00
Dismissed
MaranBr approved these changes 2025-10-07 16:13:53 +02:00
Dismissed
Ribbit commented 2025-10-07 17:29:54 +02:00
Author
Contributor
Copy link

I'm going to do a sanity check since I butchered this PR with accidental commits. Once confirmed okay I'll adjust the headers.

I'm going to do a sanity check since I butchered this PR with accidental commits. Once confirmed okay I'll adjust the headers.
Ribbit force-pushed raiichanges from c404d3e0bd to c316ebbc80 2025-10-08 03:49:48 +02:00 Compare
Ribbit dismissed CamilleLaVey's review 2025-10-08 03:49:49 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Ribbit dismissed MaranBr's review 2025-10-08 03:49:49 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

CamilleLaVey approved these changes 2025-10-08 03:51:25 +02:00
MaranBr scheduled this pull request to auto merge when all checks succeed 2025-10-08 04:01:12 +02:00
MaranBr approved these changes 2025-10-08 04:01:22 +02:00
MaranBr merged commit db65f10768 into master 2025-10-08 04:01:25 +02:00
MaranBr referenced this pull request from a commit 2025-10-08 04:01:26 +02:00
[vk] Unify RAII in Vulkan (#2679)
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
crueter
MrPurple666
Lizzie
CamilleLaVey
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2679
No description provided.
Delete branch "Ribbit/ribbitvulkanadditions:raiichanges"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?