eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[desktop] fix save data location, orphaned profiles finder #2678

Merged
crueter merged 2 commits from fix/profiles into master 2025-10-07 01:32:10 +02:00
Conversation 2 Commits 2 Files changed 11 +156 -17
crueter commented 2025-10-05 23:52:20 +02:00
Owner
Copy link

Previously, if the user had their NAND in a nonstandard location,
profiles.dat would be read from the standard Eden path and thus return
effectively garbage data. What this would result in is:

  • The Qt profile manager would be completely nonfunctional
  • "Open Save Data Location" would put you into the completely wrong
    place
  • Games would read from incorrect locations for their saves

To solve this, I made it so that profiles.dat is re-read after
QtConfig initializes. It's not the perfect solution, but it works.

Additionally, this adds an orphaned profiles finder:

  • walks through the save folders in nand/user/save/000.../
  • for each subdirectory, checks to see if profiles.dat contains a
    corresponding UUID
  • If not, the profile is "orphaned". It may contain legit save data, so
    let the user decide how to handle it (famous last words)
  • Empty profiles are just removed. If they really matter, they're
    instantly recreated anyways.

The orphaned profiles check runs right after the decryption keys
check, but before the game list ever gets populated

Signed-off-by: crueter crueter@eden-emu.dev

Previously, if the user had their NAND in a nonstandard location, profiles.dat would be read from the standard Eden path and thus return effectively garbage data. What this would result in is: - The Qt profile manager would be completely nonfunctional - "Open Save Data Location" would put you into the completely wrong place - Games would read from incorrect locations for their saves To solve this, I made it so that profiles.dat is re-read *after* QtConfig initializes. It's not the perfect solution, but it works. Additionally, this adds an orphaned profiles finder: - walks through the save folders in nand/user/save/000.../ - for each subdirectory, checks to see if profiles.dat contains a corresponding UUID - If not, the profile is "orphaned". It may contain legit save data, so let the user decide how to handle it (famous last words) - Empty profiles are just removed. If they really matter, they're instantly recreated anyways. The orphaned profiles check runs right *after* the decryption keys check, but before the game list ever gets populated Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-10-05 23:52:21 +02:00
[desktop] fix save data location, orphaned profiles finder
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
Details
33b7f39f65 
Previously, if the user had their NAND in a nonstandard location,
profiles.dat would be read from the standard Eden path and thus return
effectively garbage data. What this would result in is:

- The Qt profile manager would be completely nonfunctional
- "Open Save Data Location" would put you into the completely wrong
  place
- Games would read from incorrect locations for their saves

To solve this, I made it so that profiles.dat is re-read *after*
QtConfig initializes. It's not the perfect solution, but it works.

Additionally, this adds an orphaned profiles finder:
- walks through the save folders in nand/user/save/000.../
- for each subdirectory, checks to see if profiles.dat contains a
  corresponding UUID
- If not, the profile is "orphaned". It may contain legit save data, so
  let the user decide how to handle it (famous last words)
- Empty profiles are just removed. If they really matter, they're
  instantly recreated anyways.

The orphaned profiles check runs right *after* the decryption keys
check, but before the game list ever gets populated

Signed-off-by: crueter <crueter@eden-emu.dev>
requested reviews from CamilleLaVey, Maufeat, MrPurple666, MaranBr, Lizzie 2025-10-05 23:52:21 +02:00
crueter added 1 commit 2025-10-06 00:21:56 +02:00
oops
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
9076fa25fa 
Signed-off-by: crueter <crueter@eden-emu.dev>
CamilleLaVey approved these changes 2025-10-06 18:21:30 +02:00
MaranBr approved these changes 2025-10-06 18:22:34 +02:00
crueter merged commit badd913bee into master 2025-10-07 01:32:10 +02:00
crueter deleted branch fix/profiles 2025-10-07 01:32:10 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
MrPurple666
Lizzie
CamilleLaVey
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2678
No description provided.
Delete branch "fix/profiles"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?