eden-emu/eden
24
3
Fork 18
Code Issues 90 Pull requests 78 Projects 1 Releases 7 Wiki Activity Actions

WIP: [Vulkan] Phase 1: Descriptor Set caching #2677

Draft
wildcard wants to merge 4 commits from descriptor into master
pull from: descriptor
merge into: eden-emu:master
Conversation 1 Commits 4 Files changed 6 +54 -10
wildcard commented 2025-10-05 23:24:50 +02:00
Member
Copy link

please do performance testing and see see if anything breaks in terms of rendering

please do performance testing and see see if anything breaks in terms of rendering
[Vulkan] Phase 1: Descriptor Set caching
Some checks failed
eden-license / license-header (pull_request) Failing after 24s
Details
7435d70e1e 
wip
Update src/video_core/renderer_vulkan/vk_descriptor_pool.h
Some checks failed
eden-license / license-header (pull_request) Successful in 25s
Details
build.yml / Update src/video_core/renderer_vulkan/vk_descriptor_pool.h (pull_request) Failing after 0s
Details
trigger_release.yml / Update src/video_core/renderer_vulkan/vk_descriptor_pool.h (pull_request) Failing after 0s
Details
fe663b4467 
license fix
crueter reviewed 2025-10-06 00:38:32 +02:00
src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp Outdated
@ -517,0 +518,4 @@
VkDescriptorSet descriptor_set = VK_NULL_HANDLE;
bool needs_update = false;
if (descriptor_set_layout) {
if (uses_push_descriptor) {
crueter commented 2025-10-06 00:38:27 +02:00
Owner
Copy link

just make this a !uses_push_descriptor, generated code is the same on GCC but idk about msvc

just make this a !uses_push_descriptor, generated code is the same on GCC but idk about msvc
DraVee force-pushed descriptor from fe663b4467
Some checks failed
eden-license / license-header (pull_request) Successful in 25s
Details
build.yml / Update src/video_core/renderer_vulkan/vk_descriptor_pool.h (pull_request) Failing after 0s
Details
trigger_release.yml / Update src/video_core/renderer_vulkan/vk_descriptor_pool.h (pull_request) Failing after 0s
Details
to 80f7919eb6
Some checks reported errors
eden-license / license-header (pull_request) Successful in 18s
Details
GitHub Actions [CI] Build cancelled
Details
2025-12-08 02:25:25 +01:00 Compare
[vk] Fix identation
Some checks reported errors
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build cancelled
Details
3906715c35
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
[vk] More identation fix
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
78a3baa43c
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
DraVee changed title from [Vulkan] Phase 1: Descriptor Set caching to WIP: [Vulkan] Phase 1: Descriptor Set caching 2025-12-08 02:38:17 +01:00
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin descriptor:descriptor
git switch descriptor
Sign in to join this conversation.
Reviewers
No reviewers
MaranBr
Lizzie
CamilleLaVey
Maufeat
crueter
MrPurple666
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2677
No description provided.