eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[Vulkan] Phase 1: Descriptor Set caching #2677

Open
wildcard wants to merge 2 commits from descriptor into master
pull from: descriptor
merge into: eden-emu:master
Conversation 1 Commits 2 Files changed 6 +61 -11
wildcard commented 2025-10-05 23:24:50 +02:00
Member
Copy link

please do performance testing and see see if anything breaks in terms of rendering

please do performance testing and see see if anything breaks in terms of rendering
wildcard added 1 commit 2025-10-05 23:24:51 +02:00
[Vulkan] Phase 1: Descriptor Set caching
Some checks failed
eden-license / license-header (pull_request) Failing after 24s
Details
7435d70e1e 
wip
requested reviews from MaranBr, Lizzie, CamilleLaVey, Maufeat, crueter, MrPurple666 2025-10-05 23:24:51 +02:00
wildcard added 1 commit 2025-10-05 23:26:43 +02:00
Update src/video_core/renderer_vulkan/vk_descriptor_pool.h
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
fe663b4467 
license fix
crueter reviewed 2025-10-06 00:38:32 +02:00
src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp
@ -517,0 +518,4 @@
VkDescriptorSet descriptor_set = VK_NULL_HANDLE;
bool needs_update = false;
if (descriptor_set_layout) {
if (uses_push_descriptor) {
crueter commented 2025-10-06 00:38:27 +02:00
Owner
Copy link

just make this a !uses_push_descriptor, generated code is the same on GCC but idk about msvc

just make this a !uses_push_descriptor, generated code is the same on GCC but idk about msvc
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin descriptor:descriptor
git checkout descriptor
Sign in to join this conversation.
Reviewers
No reviewers
MaranBr
Lizzie
CamilleLaVey
Maufeat
crueter
MrPurple666
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2677
No description provided.
Delete branch "descriptor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?