eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[cmake] don't REQUIRE externals deps in root, add boost_headers #265

Merged
crueter merged 2 commits from fix/aur into master 2025-08-15 00:35:29 +02:00
Conversation 1 Commits 2 Files changed 2 +16 -5
crueter commented 2025-08-14 23:46:50 +02:00
Owner
Copy link

boost_headers is actually required for some distros apparently (notably
Arch, thanks username227 for spotting it), forces the bundled package
for it as well

AUR cpp-httplib also does not work with this for some reason, so in
order to support CMAKE_DISABLE_FIND_PACKAGE_httplib (required for
Arch if cpp-httplib is installed there), removes REQUIRED from the
external propagation calls (wasn't needed anyway idk why I added it)

I really wish we had more Arch developers tbh

Signed-off-by: crueter crueter@eden-emu.dev

boost_headers is actually required for some distros apparently (notably Arch, thanks username227 for spotting it), forces the bundled package for it as well AUR cpp-httplib also does not work with this for some reason, so in order to support `CMAKE_DISABLE_FIND_PACKAGE_httplib` (required for Arch if `cpp-httplib` is installed there), removes REQUIRED from the external propagation calls (wasn't needed anyway idk why I added it) I really wish we had more Arch developers tbh Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-14 23:46:50 +02:00
[cmake] don't REQUIRE externals deps in root, add boost_headers
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
1737ddd98d 
boost_headers is actually required for some distros apparently (notably
Arch, thanks username227 for spotting it), forces the bundled package
for it as well

AUR cpp-httplib also does not work with this for some reason, so in
order to support `CMAKE_DISABLE_FIND_PACKAGE_httplib` (required for
Arch if `cpp-httplib` is installed there), removes REQUIRED from the
external propagation calls (wasn't needed anyway idk why I added it)

I really wish we had more Arch developers tbh

Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-14 23:50:31 +02:00
[cmake] don't add boost_headers if target already exists
All checks were successful
eden-license / license-header (pull_request) Successful in 1m14s
Details
e97198def8 
ARHABGJHBASJDFJHBF

Signed-off-by: crueter <crueter@eden-emu.dev>
Lizzie approved these changes 2025-08-15 00:35:15 +02:00
crueter merged commit 9ea4e89607 into master 2025-08-15 00:35:29 +02:00
crueter deleted branch fix/aur 2025-08-15 00:35:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#265
No description provided.
Delete branch "fix/aur"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?