[compat] fix libusb when disabled error (solaris, fbsd, etc) #2649

Lizzie · 2025-10-02T03:03:37+02:00

Lizzie commented

2025-10-02 03:03:37 +02:00

This fixes an issue in builds where libusb is disabled, it also uses and prioritizes system dependencies over vendored ones (so ports is easier)

Signed-off-by: lizzie lizzie@eden-emu.dev

This fixes an issue in builds where libusb is disabled, it also uses and prioritizes system dependencies over vendored ones (so ports is easier) Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie requested reviews from crueter, CamilleLaVey, Maufeat, MrPurple666, MaranBr

2025-10-02 03:03:37 +02:00

crueter requested changes

2025-10-02 17:25:36 +02:00

Dismissed

CMakeLists.txt Outdated

					
				@ -172,3 +174,3 @@

				mark_as_advanced(FORCE ENABLE_OPENGL)

				option(ENABLE_WEB_SERVICE "Enable web services (telemetry, etc.)" ON)

				cmake_dependent_option(ENABLE_WEB_SERVICE "Enable web services (telemetry, etc.)" ON "WIN32 OR ANDROID OR PLATFORM_LINUX OR APPLE" OFF)

why?

Easier for FBSD ports when we eventually get there

It shouldn't be forced off, ever. You can change the default if you wish though

crueter marked this conversation as resolved

crueter requested changes

2025-10-04 08:34:30 +02:00

Dismissed

CMakeLists.txt Outdated

					
				@ -157,2 +157,3 @@

				option(ENABLE_CUBEB "Enables the cubeb audio backend" ON)

				# FreeBSD doesn't have a cubeb port yet, vendoring it isn't required (it's optional anyways)

				cmake_dependent_option(ENABLE_CUBEB "Enables the cubeb audio backend" ON "NOT PLATFORM_FREEBSD" OFF)

Cmake dependent option forces it off here if the fourth argument is true, so you should just do

if (PLATFORM_FREEBSD)
    set(CUBEB_DEFAULT OFF)
else()
    set(CUBEB_DEFAULT ON)
endif()

option(ENABLE_CUBEB "Enables the cubeb audio backend" ${ENABLE_CUBEB})

also, it gets vendored either way, so idk if this is even needed

Cmake dependent option *forces* it off here if the fourth argument is true, so you should just do ```cmake if (PLATFORM_FREEBSD) set(CUBEB_DEFAULT OFF) else() set(CUBEB_DEFAULT ON) endif() option(ENABLE_CUBEB "Enables the cubeb audio backend" ${ENABLE_CUBEB}) ``` also, it gets vendored either way, so idk if this is even needed