eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[ci] Minor change to fix building #2644

Merged
Shinmegumi merged 1 commit from shinmegumi-ci-fix into master 2025-10-01 21:09:29 +02:00
Conversation 2 Commits 1 Files changed 1 +1 -1
Shinmegumi commented 2025-10-01 20:07:45 +02:00
Owner
Copy link

MSVC did not like that one of our variables was a constexpr since it was defined in the externals as a constexpr. Changed to const auto like the rest to ensure it built properly.

MSVC did not like that one of our variables was a constexpr since it was defined in the externals as a constexpr. Changed to const auto like the rest to ensure it built properly.
Shinmegumi added 1 commit 2025-10-01 20:07:45 +02:00
Minor change to see if it fixes building
Some checks failed
eden-license / license-header (pull_request) Has been cancelled
Details
c5971f8696 
Minor change to see if this fixes building on CI.
requested reviews from CamilleLaVey, Maufeat, crueter, MrPurple666, MaranBr, Lizzie 2025-10-01 20:07:45 +02:00
MaranBr approved these changes 2025-10-01 20:44:20 +02:00
MaranBr scheduled this pull request to auto merge when all checks succeed 2025-10-01 20:44:28 +02:00
Maufeat approved these changes 2025-10-01 20:46:31 +02:00
Shinmegumi merged commit 61adc85c4b into master 2025-10-01 21:09:29 +02:00
Shinmegumi deleted branch shinmegumi-ci-fix 2025-10-01 21:09:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
crueter
MrPurple666
Lizzie
MaranBr
Maufeat
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2644
No description provided.
Delete branch "shinmegumi-ci-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?