WIP: [VK]Improve query reset before use so that now queries are reset outside render pass and are batched #264

Closed
wildcard wants to merge 3 commits from smartqueryreset into master
Member

Note to testers, please enable validation layers and see if there are any errors related to queries not being reset before every use, Thanks.

Note to testers, please enable validation layers and see if there are any errors related to queries not being reset before every use, Thanks.
Shinmegumi force-pushed smartqueryreset from f630a7f277
Some checks failed
eden-license / license-header (pull_request) Failing after 28s
to 456a328267
Some checks failed
eden-license / license-header (pull_request) Failing after 23s
2025-08-24 01:18:52 +02:00
Compare
Shinmegumi force-pushed smartqueryreset from 456a328267
Some checks failed
eden-license / license-header (pull_request) Failing after 23s
to 793ac9a8b1
Some checks failed
eden-license / license-header (pull_request) Failing after 23s
2025-09-01 15:30:47 +02:00
Compare
MaranBr force-pushed smartqueryreset from 170bd13e39
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
to 95b4d0b0b3
All checks were successful
eden-license / license-header (pull_request) Successful in 43s
2025-09-12 03:18:01 +02:00
Compare
Owner

@wildcard, is this PR still valid? Have you don't this in another PR or commit that was merged or should we get this tested and merged?

@wildcard, is this PR still valid? Have you don't this in another PR or commit that was merged or should we get this tested and merged?
Shinmegumi force-pushed smartqueryreset from 95b4d0b0b3
All checks were successful
eden-license / license-header (pull_request) Successful in 43s
to 6c29468a3e
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
2025-09-15 16:56:14 +02:00
Compare
Shinmegumi force-pushed smartqueryreset from 6c29468a3e
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
to 9d1964901c
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
2025-09-20 17:58:20 +02:00
Compare
Shinmegumi force-pushed smartqueryreset from 9d1964901c
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
to 8937502d46
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
2025-09-20 18:20:45 +02:00
Compare
Shinmegumi force-pushed smartqueryreset from 8937502d46
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
to bde69819ff
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
2025-09-24 18:30:34 +02:00
Compare
MaranBr force-pushed smartqueryreset from bde69819ff
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
to 59010b3ad4
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
2025-09-28 16:38:09 +02:00
Compare
Shinmegumi force-pushed smartqueryreset from 59010b3ad4
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
to 191d2570a9
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
2025-09-28 19:43:57 +02:00
Compare
DraVee force-pushed smartqueryreset from 191d2570a9
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
to 4b2380da24
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
2025-12-05 01:37:13 +01:00
Compare
DraVee force-pushed smartqueryreset from 4b2380da24
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
to 10d036b4bc
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
2025-12-07 21:56:16 +01:00
Compare
DraVee changed title from [VK]Improve query reset before use so that now queries are reset outside render pass and are batched to WIP: [VK]Improve query reset before use so that now queries are reset outside render pass and are batched 2025-12-08 00:43:11 +01:00
crueter force-pushed smartqueryreset from 10d036b4bc
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
to f3121d19f0
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
2025-12-16 20:52:47 +01:00
Compare
DraVee force-pushed smartqueryreset from f3121d19f0
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
to c15a08620c
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
2025-12-26 02:35:17 +01:00
Compare
Member

Looks like improved when used with changes from #3096 but currently on master, introduces crashs and high RAM usage

Still need to be checked again against rebased master

Looks like improved when used with changes from #3096 but currently on master, introduces crashs and high RAM usage Still need to be checked again against rebased master
DraVee force-pushed smartqueryreset from c15a08620c
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
to 8832154e6f
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
2025-12-27 18:30:52 +01:00
Compare
DraVee force-pushed smartqueryreset from 8832154e6f
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
to c70200bcc1
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published
2025-12-28 23:58:39 +01:00
Compare
Maufeat closed this pull request 2026-01-19 22:53:31 +01:00
Maufeat deleted branch smartqueryreset 2026-01-19 22:53:36 +01:00
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Required
Details
GitHub Actions [CI] Build succeeded
GitHub Releases [CD] Build succeeded – Release published

Pull request closed

Sign in to join this conversation.
No description provided.