WIP: [VK]Improve query reset before use so that now queries are reset outside render pass and are batched #264

Draft

wildcard wants to merge 3 commits from smartqueryreset into master

pull from: smartqueryreset

merge into: eden-emu:master

eden-emu:master

eden-emu:biquad_float_v2

eden-emu:quick-fix

eden-emu:dynarmic-ppc64

eden-emu:memory-use-memcpy-4rw

eden-emu:new-docs-stuff

eden-emu:scmfix-worktree

eden-emu:netgate1

eden-emu:xbzk-mci-bare-minimum-boot-fix

eden-emu:dynarm7345

eden-emu:memsetopsyscallavoid

eden-emu:pintocputhing

eden-emu:remove-unused-fastmem-fallback

eden-emu:hwaccel

eden-emu:vk-do-not-renumerate-without-reason

eden-emu:eds-true-adreno-fixes

eden-emu:pt-fix-attempt

eden-emu:descriptor

eden-emu:fix-fibers-2

eden-emu:liz-dynarmic-macos-fbsd-port

eden-emu:liz-dynarmic-backport-waitpkg

eden-emu:descriptor_pool_opt

eden-emu:mmap-fixews

eden-emu:fix/no-duplicate-drivers

eden-emu:interval-zero

eden-emu:jarrod-leaks-fix

eden-emu:sync_error_codes

eden-emu:liz-coalesce-ptr-to-variant

eden-emu:netusejthreadstuff

eden-emu:mci

eden-emu:civa

eden-emu:eden-orbis-ps4

eden-emu:kjsdfndkfn-2834

eden-emu:sjkdbsdfjkbsdf-2834

eden-emu:feat/auto-hide-controller-overlay-android

eden-emu:fw20_qlaunch

eden-emu:android/unused-strings

eden-emu:display-modified-settings-first

eden-emu:liz-ankerl-map-for-texture-cache-page-table

eden-emu:test-biquad-plus-vma

eden-emu:vk-fix-oom-force-maller-buffers

eden-emu:android/fix-gpu-driver-fetcher

eden-emu:true-eds

eden-emu:mutliplayer-filter-better1

eden-emu:rem-dup-applet-launch

eden-emu:reorder-menu-game-per-config

eden-emu:dynarmic-dtrace-1

eden-emu:overlay_fix

eden-emu:prtest-regr-of-totk-overlay

eden-emu:swizzle

eden-emu:services-relocate-to-guest

eden-emu:liz-get-rid-of-mcl-intrusive-list

eden-emu:ffmpeg-cross-compile

eden-emu:fw21fuckinghell

eden-emu:vk-use-deque-for-presentation-queue

eden-emu:dynarmic-coproc

eden-emu:lanobu

eden-emu:update-deps

eden-emu:fucking-heaptracker-regression-again

eden-emu:liz-no-rtti-allowance

eden-emu:no-shuffle

eden-emu:true-eds-graphics

eden-emu:rb-dynarmic-rendering-khr

eden-emu:sampleshaderfract

eden-emu:android6

eden-emu:update-icons-android-11

eden-emu:static-vector-thread-list

eden-emu:static-linux

eden-emu:refactor-eds2

eden-emu:xbzk-saf-recursive-write-with-permission-request

eden-emu:refactoreds2

eden-emu:no-d24

eden-emu:refactor-eds

eden-emu:stuffmadeforfun

eden-emu:date-android

eden-emu:macroify-surface-stuffs

eden-emu:chromacitiy-agbr8-fix

eden-emu:showcase2

eden-emu:pr-2981

eden-emu:nce-strx

eden-emu:showcase

eden-emu:za-toggle

eden-emu:test-revert-gpu-optim

eden-emu:camillelavey-lmao1

eden-emu:add-ext-opts

eden-emu:test-revert-a5996c7511

eden-emu:Eds-experiments

eden-emu:selfhost0

eden-emu:qcom-weird-vk-ftz

eden-emu:gpu-docs1

eden-emu:vulkan-thingy

eden-emu:android-x86_64

eden-emu:flatsops1

eden-emu:floatopsfixes1

eden-emu:vk-surface-andpc

eden-emu:fix-windows-amd

eden-emu:flatopsfixes23485

eden-emu:release/0.0.4

eden-emu:save-crash-za

eden-emu:fs_external_dlcupdates

eden-emu:discfix

eden-emu:s8e-experiment

eden-emu:lock-term-1

eden-emu:port-qtcommon

eden-emu:fix/moltenvk

eden-emu:opinion-android

eden-emu:fix/discord-rpc

eden-emu:revolt-update-to-stoat

eden-emu:liz-crash-dumps-solaris

eden-emu:sured-revert

eden-emu:macos-sqbuild

eden-emu:atomicops-mxwell

eden-emu:revert-2695

eden-emu:descriptor_set

eden-emu:n64

eden-emu:release/0.0.3

eden-emu:rework/fence_release

eden-emu:keyboard-mouse-android

eden-emu:frame-interp-rework

eden-emu:ragebound_stage41_temp_fix

eden-emu:frame-skip

eden-emu:d24

eden-emu:feature/dmnt

eden-emu:Kernel

eden-emu:nce_cpp

eden-emu:ryujinx_mmped_mem

Conversation 1 Commits 3 Files changed 5 +46 -7

wildcard commented 2025-08-14 22:01:13 +02:00

Member

Copy link

Note to testers, please enable validation layers and see if there are any errors related to queries not being reset before every use, Thanks.

Note to testers, please enable validation layers and see if there are any errors related to queries not being reset before every use, Thanks.

Shinmegumi force-pushed smartqueryreset from f630a7f277 to 456a328267 2025-08-24 01:18:52 +02:00 Compare

Shinmegumi force-pushed smartqueryreset from 456a328267 to 793ac9a8b1 2025-09-01 15:30:47 +02:00 Compare

MaranBr force-pushed smartqueryreset from 170bd13e39 to 95b4d0b0b3 2025-09-12 03:18:01 +02:00 Compare

Shinmegumi commented 2025-09-15 16:56:07 +02:00

Owner

Copy link

@wildcard, is this PR still valid? Have you don't this in another PR or commit that was merged or should we get this tested and merged?

@wildcard, is this PR still valid? Have you don't this in another PR or commit that was merged or should we get this tested and merged?

Shinmegumi force-pushed smartqueryreset from 95b4d0b0b3 to 6c29468a3e 2025-09-15 16:56:14 +02:00 Compare

Shinmegumi force-pushed smartqueryreset from 6c29468a3e to 9d1964901c 2025-09-20 17:58:20 +02:00 Compare

Shinmegumi force-pushed smartqueryreset from 9d1964901c to 8937502d46 2025-09-20 18:20:45 +02:00 Compare

Shinmegumi force-pushed smartqueryreset from 8937502d46 to bde69819ff 2025-09-24 18:30:34 +02:00 Compare

MaranBr force-pushed smartqueryreset from bde69819ff to 59010b3ad4 2025-09-28 16:38:09 +02:00 Compare

Shinmegumi force-pushed smartqueryreset from 59010b3ad4 to 191d2570a9 2025-09-28 19:43:57 +02:00 Compare

DraVee force-pushed smartqueryreset from 191d2570a9 to 4b2380da24 2025-12-05 01:37:13 +01:00 Compare

DraVee force-pushed smartqueryreset from 4b2380da24 to 10d036b4bc 2025-12-07 21:56:16 +01:00 Compare

DraVee changed title from [VK]Improve query reset before use so that now queries are reset outside render pass and are batched to WIP: [VK]Improve query reset before use so that now queries are reset outside render pass and are batched 2025-12-08 00:43:11 +01:00

DraVee added the

graphics

vulkan

labels 2025-12-08 01:03:57 +01:00

All checks were successful

Hide all checks

eden-license / license-header (pull_request) Successful in 18s

Required

Details

GitHub Actions [CI] Build succeeded

Details

GitHub Releases [CD] Build succeeded – Release published

Details

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin smartqueryreset:smartqueryreset

git switch smartqueryreset

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

android

Specific to android platform

  

audio

  

bug

Something is not working

  

ci

For changes to the ci/building

  

cmake

  

confirmed

Used when testers confirm a bug is reported and it is reproducable.

  

core

For core changes to the emulator

  

desktop

Specific to desktop PCs, handhelds, etc.

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Frontend changes

  

fw

Changes related to firmware

  

git

For enhancements or changes regarding git.

  

graphics

  

loader

For changes to any of the loader implementations

  

nv gpu

For use with changes that involve the emulator GPU and any services.

  

ui

  

vulkan

Used on anything Vulkan-related

No labels

android

audio

bug

ci

cmake

confirmed

core

desktop

duplicate

enhancement

frontend

fw

git

graphics

loader

nv gpu

ui

vulkan

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

eden-emu/eden!264

No description provided.