eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[core] use memcpy instead of hand rolling aligned cases #2639

Open
Lizzie wants to merge 2 commits from memory-use-memcpy-4rw into master
pull from: memory-use-memcpy-4rw
merge into: eden-emu:master
Conversation 1 Commits 2 Files changed 1 +36 -167
Lizzie commented 2025-10-01 10:05:40 +02:00
Member
Copy link

Hand rolling memcpy like this is always frowned upon because the compiler has more insight on whats going on (plus the code resolves to a worse version of itself on assembly). This removes some branches that are just straight up redundant. May save stuff especially for systems without fastmem enabled.

Signed-off-by: lizzie lizzie@eden-emu.dev

Hand rolling memcpy like this is always frowned upon because the compiler has more insight on whats going on (plus the code resolves to a worse version of itself on assembly). This removes some branches that are just straight up redundant. May save stuff especially for systems without fastmem enabled. Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-10-01 10:05:40 +02:00
[core] use memcpy instead of hand rolling aligned cases
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
6e3a943e74 
Hand rolling memcpy like this is always frowned upon because the compiler has more insight on whats going on (plus the code resolves to a worse version of itself on assembly). This removes some branches that are just straight up redundant. May save stuff especially for systems without fastmem enabled.

Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested reviews from CamilleLaVey, Maufeat, crueter, MrPurple666, MaranBr 2025-10-01 10:05:40 +02:00
Lizzie force-pushed memory-use-memcpy-4rw from 6e3a943e74 to 613ffac2b9 2025-10-01 23:52:59 +02:00 Compare
DraVee commented 2025-10-02 05:21:56 +02:00
Member
Copy link

Build failed, check:
#2639

Build failed, check: [#2639](https://github.com/Eden-CI/Workflow/actions/runs/18176679804)
Lizzie force-pushed memory-use-memcpy-4rw from 613ffac2b9 to 91432e336a 2025-10-02 06:53:44 +02:00 Compare
Lizzie added 1 commit 2025-10-02 07:22:36 +02:00
fix
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
b332ce0e51 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed memory-use-memcpy-4rw from b332ce0e51 to 90961d3695 2025-10-02 23:17:46 +02:00 Compare
Shinmegumi force-pushed memory-use-memcpy-4rw from 90961d3695 to ec56567886 2025-10-03 20:56:53 +02:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from ec56567886 to 73a043f64b 2025-10-04 09:35:54 +02:00 Compare
MaranBr force-pushed memory-use-memcpy-4rw from 73a043f64b to bf4e271cb3 2025-10-04 23:59:50 +02:00 Compare
MaranBr force-pushed memory-use-memcpy-4rw from bf4e271cb3 to 0c751bd96d 2025-10-05 00:04:26 +02:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from 0c751bd96d to f58a7f1ca3 2025-10-07 05:36:36 +02:00 Compare
Shinmegumi force-pushed memory-use-memcpy-4rw from f58a7f1ca3 to acc93cb564 2025-10-07 19:02:25 +02:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin memory-use-memcpy-4rw:memory-use-memcpy-4rw
git checkout memory-use-memcpy-4rw
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
crueter
MrPurple666
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2639
No description provided.
Delete branch "memory-use-memcpy-4rw"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?