eden-emu/eden
24
3
Fork 18
Code Issues 90 Pull requests 78 Projects 1 Releases 7 Wiki Activity Actions

[core] use memcpy instead of hand rolling aligned cases #2639

Open
Lizzie wants to merge 2 commits from memory-use-memcpy-4rw into master
pull from: memory-use-memcpy-4rw
merge into: eden-emu:master
Conversation 7 Commits 2 Files changed 1 +36 -167
Lizzie commented 2025-10-01 10:05:40 +02:00
Member
Copy link

Hand rolling memcpy like this is always frowned upon because the compiler has more insight on whats going on (plus the code resolves to a worse version of itself on assembly). This removes some branches that are just straight up redundant. May save stuff especially for systems without fastmem enabled.

Signed-off-by: lizzie lizzie@eden-emu.dev

Hand rolling memcpy like this is always frowned upon because the compiler has more insight on whats going on (plus the code resolves to a worse version of itself on assembly). This removes some branches that are just straight up redundant. May save stuff especially for systems without fastmem enabled. Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed memory-use-memcpy-4rw from 6e3a943e74
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
to 613ffac2b9
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
Details
2025-10-01 23:52:59 +02:00 Compare
DraVee commented 2025-10-02 05:21:56 +02:00
Member
Copy link

Build failed, check:
#2639

Build failed, check: [#2639](https://github.com/Eden-CI/Workflow/actions/runs/18176679804)
Lizzie force-pushed memory-use-memcpy-4rw from 613ffac2b9
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
Details
to 91432e336a
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
2025-10-02 06:53:44 +02:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from b332ce0e51
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to 90961d3695
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
2025-10-02 23:17:46 +02:00 Compare
Shinmegumi force-pushed memory-use-memcpy-4rw from 90961d3695
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
to ec56567886
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
2025-10-03 20:56:53 +02:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from ec56567886
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to 73a043f64b
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
2025-10-04 09:35:54 +02:00 Compare
MaranBr force-pushed memory-use-memcpy-4rw from 73a043f64b
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
to bf4e271cb3
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
2025-10-04 23:59:50 +02:00 Compare
MaranBr force-pushed memory-use-memcpy-4rw from bf4e271cb3
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
to 0c751bd96d
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
2025-10-05 00:04:26 +02:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from 0c751bd96d
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
to f58a7f1ca3
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
2025-10-07 05:36:36 +02:00 Compare
Shinmegumi force-pushed memory-use-memcpy-4rw from f58a7f1ca3
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
to acc93cb564
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
2025-10-07 19:02:25 +02:00 Compare
crueter approved these changes 2025-10-15 22:23:11 +02:00
Dismissed
MaranBr approved these changes 2025-10-22 02:22:29 +02:00
Dismissed
DraVee commented 2025-10-22 02:28:42 +02:00
Member
Copy link

Need rebase

Need rebase
crueter approved these changes 2025-10-22 04:56:13 +02:00
Dismissed
MaranBr approved these changes 2025-10-29 04:34:25 +01:00
Dismissed
DraVee commented 2025-10-29 04:36:28 +01:00
Member
Copy link

Needs testing before merge

Needs testing before merge
Shinmegumi force-pushed memory-use-memcpy-4rw from acc93cb564
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
to 756bcf3dab
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-29 13:08:41 +01:00 Compare
Shinmegumi force-pushed memory-use-memcpy-4rw from 756bcf3dab
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to f8b50875fc
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-29 14:51:12 +01:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from f8b50875fc
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 6e8cdf5bff
Some checks failed
eden-license / license-header (pull_request) Successful in 48s
Details
GitHub Actions [CI] Build failed
Details
2025-10-31 22:47:31 +01:00 Compare
Lizzie dismissed crueter's review 2025-10-31 22:47:31 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie dismissed MaranBr's review 2025-10-31 22:47:31 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie force-pushed memory-use-memcpy-4rw from 6e8cdf5bff
Some checks failed
eden-license / license-header (pull_request) Successful in 48s
Details
GitHub Actions [CI] Build failed
Details
to c82c491423
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-11-07 04:07:26 +01:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from c82c491423
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to d43f4725c8
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-11-12 12:01:33 +01:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from d43f4725c8
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 8565d8a487
All checks were successful
eden-license / license-header (pull_request) Successful in 45s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-11-25 10:38:14 +01:00 Compare
DraVee force-pushed memory-use-memcpy-4rw from 8565d8a487
All checks were successful
eden-license / license-header (pull_request) Successful in 45s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 8905a08df1
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-12-08 01:47:48 +01:00 Compare
Lizzie force-pushed memory-use-memcpy-4rw from 8905a08df1
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to c48cd92f4c
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-12-10 11:38:55 +01:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin memory-use-memcpy-4rw:memory-use-memcpy-4rw
git switch memory-use-memcpy-4rw
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
crueter
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2639
No description provided.