CMake improvements: ccache, bundled Qt, MoltenVK, LTO, and Linux deps #2622

Merged
CamilleLaVey merged 6 commits from DraVee/eden:cmake/externals-fixup into master 2025-09-30 02:51:49 +02:00
Member
  • Fix YUZU_USE_BUNDLED_QT on Linux (correct path is gcc_64 for Qt 6.8.3).
  • Implement USE_CCACHE correctly (additional changes on #2580).
  • Categorize and organize CMake options for clarity.
  • Add missing Linux dependencies
  • Set CMP0069 (LTO) default behavior to NEW to reduce warnings.
  • Replace USE_SYSTEM_MOLTENVK with YUZU_APPLE_USE_BUNDLED_MONTENVK and remove duplicate download_moltenvk.
- Fix YUZU_USE_BUNDLED_QT on Linux (correct path is gcc_64 for Qt 6.8.3). - Implement USE_CCACHE correctly (additional changes on #2580). - Categorize and organize CMake options for clarity. - Add missing Linux dependencies - Set CMP0069 (LTO) default behavior to NEW to reduce warnings. - Replace USE_SYSTEM_MOLTENVK with YUZU_APPLE_USE_BUNDLED_MONTENVK and remove duplicate download_moltenvk.
DraVee added 6 commits 2025-09-30 01:19:14 +02:00
* the correct path (at least for 6.8.3) is gcc_64 and not linux

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
* remove duplicated download_moltenvk*
* add other smalls fixes

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
* as stated on https://cmake.org/cmake/help/latest/policy/CMP0069.html
* and should reduce warnings
* picked from ninja-build/ninja

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
* i think it should be added to the build.sh later

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
* it's a lot better for the eyes

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
CMake: Implement correct USE_CCACHE
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
b625453d06
* it depends on changes made on 9f137adad7

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
requested reviews from Maufeat, MrPurple666, MaranBr, Lizzie, crueter, CamilleLaVey 2025-09-30 01:19:15 +02:00
crueter requested changes 2025-09-30 02:21:04 +02:00
crueter left a comment
Owner

A lot of these comments are generally unnecessary. Some of them are kinda wrong too

A lot of these comments are generally unnecessary. Some of them are kinda wrong too
DraVee force-pushed cmake/externals-fixup from b625453d06 to b8fbdfaeeb 2025-09-30 02:27:59 +02:00 Compare
Author
Member

@crueter wrote in #2622 (comment):

A lot of these comments are generally unnecessary. Some of them are kinda wrong too

Sorry was rebasing, i will check it

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/2622#issuecomment-5308: > A lot of these comments are generally unnecessary. Some of them are kinda wrong too Sorry was rebasing, i will check it
DraVee force-pushed cmake/externals-fixup from b8fbdfaeeb to ce80a2e6a9 2025-09-30 02:35:25 +02:00 Compare
requested review from crueter 2025-09-30 02:36:26 +02:00
MaranBr approved these changes 2025-09-30 02:48:09 +02:00
CamilleLaVey approved these changes 2025-09-30 02:48:53 +02:00
CamilleLaVey merged commit 815d85677a into master 2025-09-30 02:51:49 +02:00
CamilleLaVey deleted branch cmake/externals-fixup 2025-09-30 02:51:49 +02:00
Sign in to join this conversation.
No description provided.