eden-emu/eden
24
3
Fork 18
Code Issues 90 Pull requests 78 Projects 1 Releases 7 Wiki Activity Actions

[dynarmic] backport WAITPKG based spinlocks #2614

Open
Lizzie wants to merge 2 commits from liz-dynarmic-backport-waitpkg into master
pull from: liz-dynarmic-backport-waitpkg
merge into: eden-emu:master
Conversation 2 Commits 2 Files changed 6 +44 -8
Lizzie commented 2025-09-29 10:33:32 +02:00
Member
Copy link

Alder Lake/Tremont or superior feature only, based on archived UMWAIT by @Wunkolo. With some fixes due to register corruption/clobber (regalloc was blind to this)

Signed-off-by: lizzie lizzie@eden-emu.dev

Alder Lake/Tremont or superior feature only, based on archived UMWAIT by @Wunkolo. With some fixes due to register corruption/clobber (regalloc was blind to this) Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed liz-dynarmic-backport-waitpkg from 0f2c89c536
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
to 5534cebe1c
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
2025-09-29 18:50:59 +02:00 Compare
MaranBr force-pushed liz-dynarmic-backport-waitpkg from 5534cebe1c
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
to 0f97b2c4bf
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
2025-09-30 02:28:12 +02:00 Compare
Lizzie force-pushed liz-dynarmic-backport-waitpkg from 0f97b2c4bf
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
to 8a185ac1be
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
2025-09-30 10:35:55 +02:00 Compare
MaranBr force-pushed liz-dynarmic-backport-waitpkg from 8a185ac1be
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
to bbb4302adc
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
2025-10-01 03:30:17 +02:00 Compare
MaranBr force-pushed liz-dynarmic-backport-waitpkg from bbb4302adc
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
to d3b89f1a04
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
2025-10-01 07:03:30 +02:00 Compare
MaranBr approved these changes 2025-10-01 07:03:35 +02:00
Dismissed
Lizzie force-pushed liz-dynarmic-backport-waitpkg from d3b89f1a04
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
to d1bac2308f
All checks were successful
eden-license / license-header (pull_request) Successful in 5m29s
Details
2025-10-02 23:23:23 +02:00 Compare
Lizzie force-pushed liz-dynarmic-backport-waitpkg from d1bac2308f
All checks were successful
eden-license / license-header (pull_request) Successful in 5m29s
Details
to 622725c383
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
2025-10-04 09:35:23 +02:00 Compare
MaranBr force-pushed liz-dynarmic-backport-waitpkg from 622725c383
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
to d7558be543
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
2025-10-05 00:04:47 +02:00 Compare
Lizzie force-pushed liz-dynarmic-backport-waitpkg from d7558be543
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
to 58357faae0
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
2025-10-08 02:23:54 +02:00 Compare
Lizzie force-pushed liz-dynarmic-backport-waitpkg from 58357faae0
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to 930445f584
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
2025-10-15 05:22:23 +02:00 Compare
crueter commented 2025-10-15 18:54:18 +02:00
Owner
Copy link
/__w/Workflow/Workflow/src/dynarmic/src/dynarmic/../dynarmic/backend/x64/emit_x64_memory.cpp.inc: In member function ‘void Dynarmic::Backend::X64::A32EmitX64::EmitExclusiveWriteMemoryInline(Dynarmic::Backend::X64::A32EmitContext&, Dynarmic::IR::Inst*)’:
/__w/Workflow/Workflow/src/dynarmic/src/dynarmic/../dynarmic/backend/x64/emit_x64_memory.cpp.inc:437:22: error: no matching function for call to ‘EmitExclusiveLock(Dynarmic::Backend::X64::BlockOfCode&, const Dynarmic::A32::UserConfig&, const Xbyak::Reg64&, const Xbyak::Reg64&)’ [-Wtemplate-body]
  437 |     EmitExclusiveLock(code, conf, tmp, tmp2);
      |     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
``` /__w/Workflow/Workflow/src/dynarmic/src/dynarmic/../dynarmic/backend/x64/emit_x64_memory.cpp.inc: In member function ‘void Dynarmic::Backend::X64::A32EmitX64::EmitExclusiveWriteMemoryInline(Dynarmic::Backend::X64::A32EmitContext&, Dynarmic::IR::Inst*)’: /__w/Workflow/Workflow/src/dynarmic/src/dynarmic/../dynarmic/backend/x64/emit_x64_memory.cpp.inc:437:22: error: no matching function for call to ‘EmitExclusiveLock(Dynarmic::Backend::X64::BlockOfCode&, const Dynarmic::A32::UserConfig&, const Xbyak::Reg64&, const Xbyak::Reg64&)’ [-Wtemplate-body] 437 | EmitExclusiveLock(code, conf, tmp, tmp2); | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ ```
Lizzie force-pushed liz-dynarmic-backport-waitpkg from 930445f584
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
to f7bfb6e1ff
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-11-07 04:02:53 +01:00 Compare
Lizzie dismissed MaranBr's review 2025-11-07 04:02:54 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie force-pushed liz-dynarmic-backport-waitpkg from f7bfb6e1ff
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 5698155700
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-11-12 12:01:20 +01:00 Compare
DraVee force-pushed liz-dynarmic-backport-waitpkg from 5698155700
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 9217a69385
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-12-08 01:46:43 +01:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
This pull request has changes conflicting with the target branch.
  • src/dynarmic/src/dynarmic/backend/x64/emit_x64_memory.cpp.inc
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin liz-dynarmic-backport-waitpkg:liz-dynarmic-backport-waitpkg
git switch liz-dynarmic-backport-waitpkg
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
crueter
MrPurple666
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2614
No description provided.