eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[dynarmic] add safe-opt to skip IR verification #2613

Merged
MaranBr merged 1 commit from liz-safe-opt-skip-verif into master 2025-10-02 23:20:47 +02:00
Conversation 4 Commits 1 Files changed 2 +9 -4
Lizzie commented 2025-09-29 09:55:40 +02:00
Member
Copy link

Most programs are well behaved and don't cause internal IR issues. Hence, verification can be safely skipped.

Signed-off-by: lizzie lizzie@eden-emu.dev

Most programs are well behaved and don't cause internal IR issues. Hence, verification can be safely skipped. Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-29 09:55:41 +02:00
[dynarmic] add safe-opt to skip IR verification
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
e8e6351d5c 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested reviews from crueter, MrPurple666, MaranBr, CamilleLaVey, Maufeat 2025-09-29 09:55:41 +02:00
Lizzie force-pushed liz-safe-opt-skip-verif from e8e6351d5c to 8e0fdff833 2025-09-29 18:51:14 +02:00 Compare
Lizzie force-pushed liz-safe-opt-skip-verif from 8e0fdff833 to 071d9bd199 2025-09-30 10:37:15 +02:00 Compare
MaranBr force-pushed liz-safe-opt-skip-verif from 071d9bd199 to 2bc62e5e9c 2025-10-01 03:30:32 +02:00 Compare
MaranBr force-pushed liz-safe-opt-skip-verif from 2bc62e5e9c to 14d3578b5b 2025-10-01 07:02:35 +02:00 Compare
MaranBr approved these changes 2025-10-01 07:02:41 +02:00
MaranBr scheduled this pull request to auto merge when all checks succeed 2025-10-01 07:02:47 +02:00
CamilleLaVey approved these changes 2025-10-02 23:20:45 +02:00
MaranBr merged commit de594c8792 into master 2025-10-02 23:20:47 +02:00
MaranBr deleted branch liz-safe-opt-skip-verif 2025-10-02 23:20:48 +02:00
crueter requested changes 2025-10-02 23:21:41 +02:00
crueter left a comment
Owner
Copy link

Is there any way to actually change the DisableVerification flag?

Is there any way to actually change the DisableVerification flag?
Lizzie commented 2025-10-02 23:26:06 +02:00
Author
Member
Copy link

@crueter wrote in #2613 (comment):

Is there any way to actually change the DisableVerification flag?

No UI for it at the moment.
HOWEVER, verification pass triggering an assert is so extremely rare that I'd just say it's impossible to trigger at all.

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/2613#issuecomment-5729: > Is there any way to actually change the DisableVerification flag? No UI for it at the moment. HOWEVER, verification pass triggering an assert is so extremely rare that I'd just say it's impossible to trigger at all.
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
Maufeat
MaranBr
CamilleLaVey
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2613
No description provided.
Delete branch "liz-safe-opt-skip-verif"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?