eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[common] revert "replace Common::BitSet with std::bitset" #2596

Closed
crueter wants to merge 1 commit from revert-bitset into master
pull from: revert-bitset
merge into: eden-emu:master
Conversation 1 Commits 1 Files changed 3 +98 -18
crueter commented 2025-09-27 07:59:33 +02:00
Owner
Copy link

this commit appears to cause some games to not boot on certain platforms (Linux is unaffected)--needs testing since this may be a linker issue

this commit appears to cause some games to not boot on certain platforms (Linux is unaffected)--needs testing since this may be a linker issue
crueter added 1 commit 2025-09-27 07:59:34 +02:00
[common] revert "replace Common::BitSet with std::bitset"
Some checks failed
eden-license / license-header (pull_request) Failing after 25s
Details
1c97fe3340 
this commit appears to cause some games to not boot on certain platforms (Linux is unaffected)--needs testing since this may be a linker issue
requested reviews from CamilleLaVey, Maufeat, MrPurple666, MaranBr, Lizzie 2025-09-27 07:59:34 +02:00
marcin-serwin commented 2025-09-27 10:29:04 +02:00
Member
Copy link

It also affects my Nix build on Linux.

It also affects my Nix build on Linux.
crueter closed this pull request 2025-09-27 17:55:23 +02:00
Some checks failed
eden-license / license-header (pull_request) Failing after 25s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
MaranBr
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2596
No description provided.
Delete branch "revert-bitset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?