eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[cmake] Fix building on aarch64-linux #2591

Merged
crueter merged 3 commits from marcin-serwin/eden:push-kkpwkkxqsysr into master 2025-09-26 21:46:57 +02:00
Conversation 4 Commits 3 Files changed 3 +5 -4
marcin-serwin commented 2025-09-26 21:37:19 +02:00
Member
Copy link
No description provided.
marcin-serwin added 3 commits 2025-09-26 21:37:20 +02:00 
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
nce: fix variable shadowing a member of std::hash
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
1734498e59 
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
requested reviews from MrPurple666, MaranBr, Lizzie, crueter, CamilleLaVey, Maufeat 2025-09-26 21:37:20 +02:00
crueter requested changes 2025-09-26 21:38:58 +02:00
Dismissed
src/core/CMakeLists.txt Outdated
@ -1225,3 +1225,3 @@
arm/nce/visitor_base.h
)
target_link_libraries(core PRIVATE merry::mcl merry::oaknut)
find_package(oaknut 2.0.1 REQUIRED)
crueter commented 2025-09-26 21:38:56 +02:00
Owner
Copy link

Like with xbyak we can move this find_package to the root with all of the other externals propagation things, in the same if block as oaknut in externals if (ARCHITECTURE_arm64 OR DYNARMIC_TESTS)

Like with xbyak we can move this find_package to the root with all of the other externals propagation things, in the same if block as oaknut in externals `if (ARCHITECTURE_arm64 OR DYNARMIC_TESTS)`
marcin-serwin commented 2025-09-26 21:42:40 +02:00
Author
Member
Copy link

Done

Done
marcin-serwin marked this conversation as resolved
marcin-serwin force-pushed push-kkpwkkxqsysr from 1734498e59 to 393324bbe1 2025-09-26 21:42:25 +02:00 Compare
crueter approved these changes 2025-09-26 21:44:06 +02:00
Dismissed
marcin-serwin force-pushed push-kkpwkkxqsysr from 393324bbe1 to ffc0b99930 2025-09-26 21:45:41 +02:00 Compare
marcin-serwin dismissed crueter's review 2025-09-26 21:45:41 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie approved these changes 2025-09-26 21:45:51 +02:00
Lizzie left a comment
Member
Copy link

Didn't have issues when building on ChromeOS; but I guess Linux differs

Didn't have issues when building on ChromeOS; but I guess Linux differs
crueter approved these changes 2025-09-26 21:46:53 +02:00
crueter merged commit f088f028f3 into master 2025-09-26 21:46:57 +02:00
crueter deleted branch push-kkpwkkxqsysr 2025-09-26 21:46:57 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
MaranBr
CamilleLaVey
Maufeat
Lizzie
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2591
No description provided.
Delete branch "marcin-serwin/eden:push-kkpwkkxqsysr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?