eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[core/memory] Remove defered heap allocation on Linux. #2587

Open
Lizzie wants to merge 3 commits from bl-heaptrackfix-defer into master
pull from: bl-heaptrackfix-defer
merge into: eden-emu:master
Conversation 1 Commits 3 Files changed 8 +34 -148
Lizzie commented 2025-09-26 10:10:40 +02:00
Member
Copy link

Authored-by: weakboson weakboson@eden-emu.dev
Signed-off-by: lizzie lizzie@eden-emu.dev

Authored-by: weakboson <weakboson@eden-emu.dev> Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-26 10:10:41 +02:00
[core/memory] Remove defered heap allocation on Linux.
Some checks failed
eden-license / license-header (pull_request) Failing after 24s
Details
9a1c9d5622 
Authored-by: weakboson <weakboson@eden-emu.dev>
Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested reviews from crueter, CamilleLaVey, Maufeat, MrPurple666, MaranBr 2025-09-26 10:10:41 +02:00
Lizzie added 1 commit 2025-09-26 10:12:00 +02:00
fix
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
abcf24a79b 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed bl-heaptrackfix-defer from abcf24a79b to ddb09e5486 2025-09-27 15:10:04 +02:00 Compare
MaranBr force-pushed bl-heaptrackfix-defer from ddb09e5486 to b17b696f51 2025-09-28 07:57:37 +02:00 Compare
MaranBr force-pushed bl-heaptrackfix-defer from b17b696f51 to 4ff48e0168 2025-09-30 02:26:31 +02:00 Compare
Lizzie force-pushed bl-heaptrackfix-defer from 4ff48e0168 to ad07f4c0f6 2025-10-01 03:44:39 +02:00 Compare
DraVee requested changes 2025-10-01 06:40:06 +02:00
src/common/heap_tracker.cpp Outdated
@ -8,3 +8,3 @@
#include "common/heap_tracker.h"
#include "common/logging/log.h"
#include "common/assert.h"
DraVee commented 2025-10-01 06:38:06 +02:00
Member
Copy link

Needed on line 108

Needed on line 108
src/common/heap_tracker.cpp Outdated
@ -148,3 +168,3 @@
// Clamp to end.
next = (std::min)(next, end);
next = std::min(next, end);
DraVee commented 2025-10-01 06:38:59 +02:00
Member
Copy link

Should be (std::min) cause aarch64, i think

Should be (std::min) cause aarch64, i think
Lizzie commented 2025-10-04 09:35:11 +02:00
Author
Member
Copy link

what??

what??
DraVee commented 2025-10-07 07:21:34 +02:00
Member
Copy link

I remember you did some changes related to putting () on std::min and std::max when enabling clang-cl (and I'm almost pretty sure it didn't generated a build of this PR)

I remember you did some changes related to putting () on std::min and std::max when enabling clang-cl (and I'm almost pretty sure it didn't generated a build of this PR)
crueter commented 2025-10-10 02:49:22 +02:00
Owner
Copy link

clang-cl will murder you if you don't use parentheses

clang-cl will murder you if you don't use parentheses
src/common/heap_tracker.cpp Outdated
@ -215,3 +191,2 @@
// lock contention.
std::size_t const desired_count = (std::min)(m_resident_map_count, m_max_resident_map_count) / 2;
std::size_t const evict_count = m_resident_map_count - desired_count;
const size_t desired_count = std::min(m_resident_map_count, m_max_resident_map_count) / 2;
DraVee commented 2025-10-01 06:39:54 +02:00
Member
Copy link

Same as previous

Same as previous
Lizzie force-pushed bl-heaptrackfix-defer from ad07f4c0f6 to 21b4c2fe86 2025-10-04 09:34:55 +02:00 Compare
Lizzie force-pushed bl-heaptrackfix-defer from 21b4c2fe86 to a0be40edf6 2025-10-10 06:06:25 +02:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin bl-heaptrackfix-defer:bl-heaptrackfix-defer
git checkout bl-heaptrackfix-defer
Sign in to join this conversation.
Reviewers
No reviewers
crueter
CamilleLaVey
Maufeat
MrPurple666
MaranBr
DraVee
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2587
No description provided.
Delete branch "bl-heaptrackfix-defer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?