From 68c09d006e44888cb6acbb0f168b5149965be134 Mon Sep 17 00:00:00 2001 From: nyx Date: Thu, 25 Sep 2025 17:24:59 +0200 Subject: [PATCH 1/3] [cmake, macos] Suppress warnings for unused private members --- src/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 184b049d06..ce0b1f8889 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -139,6 +139,7 @@ else() -Wno-invalid-offsetof -Wno-unused-parameter -Wno-missing-field-initializers + -Wno-unused-private-field ) if (CXX_CLANG OR CXX_ICC) # Clang or AppleClang -- 2.39.5 From 0b4e8df6bd00061f38b20778dcaf532b3c33376f Mon Sep 17 00:00:00 2001 From: nyx Date: Thu, 25 Sep 2025 17:49:25 +0200 Subject: [PATCH 2/3] limit to apple only --- src/CMakeLists.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index ce0b1f8889..7d8d09c67e 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -139,7 +139,6 @@ else() -Wno-invalid-offsetof -Wno-unused-parameter -Wno-missing-field-initializers - -Wno-unused-private-field ) if (CXX_CLANG OR CXX_ICC) # Clang or AppleClang @@ -166,6 +165,10 @@ else() add_compile_options("-stdlib=libc++") endif() + if (CXX_APPLE) + add_compile_options(-Wno-unused-private-field) + endif() + # GCC bugs if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "11" AND CXX_GCC) # These diagnostics would be great if they worked, but are just completely broken -- 2.39.5 From 5b3b127f8384b64a591bc997d7913edc3f7ac63b Mon Sep 17 00:00:00 2001 From: crueter Date: Fri, 26 Sep 2025 19:09:37 -0400 Subject: [PATCH 3/3] add to existing icc/clang block Signed-off-by: crueter --- src/CMakeLists.txt | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 7d8d09c67e..88470c4c42 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -141,7 +141,7 @@ else() -Wno-missing-field-initializers ) - if (CXX_CLANG OR CXX_ICC) # Clang or AppleClang + if (CXX_CLANG OR CXX_ICC OR CXX_APPLE) # Clang, AppleClang, or Intel C++ if (NOT MSVC) add_compile_options( -Werror=shadow-uncaptured-local @@ -165,10 +165,6 @@ else() add_compile_options("-stdlib=libc++") endif() - if (CXX_APPLE) - add_compile_options(-Wno-unused-private-field) - endif() - # GCC bugs if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "11" AND CXX_GCC) # These diagnostics would be great if they worked, but are just completely broken -- 2.39.5