eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[ci] license-header.sh: Make it POSIX-compliant! #2579

Open
DraVee wants to merge 3 commits from DraVee/eden:scripts/license into master
pull from: DraVee/eden:scripts/license
merge into: eden-emu:master
Conversation 1 Commits 3 Files changed 1 +174 -109
DraVee commented 2025-09-25 16:47:04 +02:00
Member
Copy link

Signed-off-by: Caio Oliveira caiooliveirafarias0@gmail.com

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
DraVee added 1 commit 2025-09-25 16:47:04 +02:00
[ci] license-header.sh: Make it POSIX-compliant!
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
2832fea64b 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
requested reviews from crueter, MrPurple666, MaranBr, Lizzie, CamilleLaVey, Maufeat 2025-09-25 16:47:04 +02:00
crueter added 1 commit 2025-09-27 01:38:18 +02:00
[ci] license-header.sh: add file exclusion capability
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
Details
8db82e55f9 
Signed-off-by: crueter <crueter@eden-emu.dev>
DraVee reviewed 2025-09-27 05:23:26 +02:00
.ci/license-header.sh Outdated
@ -6,1 +6,3 @@
echo "Getting branch changes"
# specify full path if dupes may exist
EXCLUDE_FILES="CPM.cmake CPMUtil.cmake GetSCMRev.cmake"
EXCLUDE_FILES=$(sed "s/ /\\\\|/g" <<< "$EXCLUDE_FILES")
DraVee commented 2025-09-27 05:23:16 +02:00
Author
Member
Copy link

"<<<" is a bash extension and not posix compliant

"<<<" is a bash extension and not posix compliant
DraVee commented 2025-09-27 05:25:43 +02:00
Author
Member
Copy link

https://www.shellcheck.net/wiki/SC3011

https://www.shellcheck.net/wiki/SC3011
crueter commented 2025-09-27 05:37:39 +02:00
Owner
Copy link

I love when every shell on my system happens to implement the few extensions that I actually use

I love when every shell on my system happens to implement the few extensions that I actually use
😆 1
DraVee marked this conversation as resolved
DraVee changed title from [ci] license-header.sh: Make it POSIX-compliant! to WIP: [ci] license-header.sh: Make it POSIX-compliant! 2025-09-27 05:30:06 +02:00
DraVee force-pushed scripts/license from 8db82e55f9 to 35897434ac 2025-09-29 00:52:48 +02:00 Compare
DraVee changed title from WIP: [ci] license-header.sh: Make it POSIX-compliant! to [ci] license-header.sh: Make it POSIX-compliant! 2025-09-29 00:53:28 +02:00
MaranBr force-pushed scripts/license from 35897434ac to 4300f65dc0 2025-09-30 02:25:46 +02:00 Compare
DraVee force-pushed scripts/license from 4300f65dc0 to 8efba93294 2025-10-01 06:57:43 +02:00 Compare
DraVee force-pushed scripts/license from 8efba93294 to 17899b18c1 2025-10-09 09:38:07 +02:00 Compare
DraVee force-pushed scripts/license from 17899b18c1 to a7f932438b 2025-10-10 02:52:29 +02:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u scripts/license:DraVee-scripts/license
git checkout DraVee-scripts/license
Sign in to join this conversation.
Reviewers
No reviewers
crueter
MrPurple666
MaranBr
Lizzie
CamilleLaVey
Maufeat
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2579
No description provided.
Delete branch "DraVee/eden:scripts/license"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?